Re: [PATH 08/19] jfs: new export ops

[Christoph Hellwig <hch@lst.de>]

On Mon, Sep 10, 2007 at 03:45:33PM -0400, J. Bruce Fields wrote:
> On Thu, Aug 30, 2007 at 03:16:32PM +0200, Christoph Hellwig wrote:
> > Trivial switch over to the new generic helpers.
> > -	    	result = ERR_PTR(-ESTALE);
> > -		goto out_iput;
> > +		iput(inode);
> > +	    	return ERR_PTR(-ESTALE);
> 
> For some reason you're introducing a bunch of whitespace damage on lines
> like that last one.  Would you mind running these through checkpatch.pl
> or whatever and then resending?
> 
> Other than that I can't find any problem, and it seems like an obvious
> improvement, though I'd like to see Neil take a look.  Do you want these
> added to the nfsd patches for 2.6.24?

Yes, please add them to the queue.  I've put a quilt series of patches
with the whitespace fixe on http://verein.lst.de/~hch/patches.nfsd.tgz.
Do you want to take it that way or should I resend everything to the
list?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs