All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] [ARM] Fix DECLARE_GLOBAL_DATA_PTR and make gd global
Date: Sat, 15 Sep 2007 09:43:03 +0200	[thread overview]
Message-ID: <20070915074303.0DFC024669@gemini.denx.de> (raw)
In-Reply-To: Your message of "Sat, 15 Sep 2007 07:44:37 +0200." <46EB7145.1050307@googlemail.com>

In message <46EB7145.1050307@googlemail.com> you wrote:
>
> Some users [1] with (some?) ARM toolchains report issues with
> #define DECLARE_GLOBAL_DATA_PTR     register volatile gd_t *gd asm ("r8")
> in include/asm-arm/global_data.h
> The issue seems to be [2]

Can you please point out specific boards that show this problem?

> This patch makes DECLARE_GLOBAL_DATA_PTR empty, so no local register
> variable any more, and makes gd global.

Actually this should not be  needed  any  more  as  all  use  of  the
DECLARE_GLOBAL_DATA_PTR  (should)  have  been  moved outside function
bodies, so we already use a global definition. If there are remaining
places where this has been forgotten I'd rather fix these.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Youth doesn't excuse everything.
	-- Dr. Janice Lester (in Kirk's body), "Turnabout Intruder",
	   stardate 5928.5.

  reply	other threads:[~2007-09-15  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-15  5:44 [U-Boot-Users] [PATCH] [ARM] Fix DECLARE_GLOBAL_DATA_PTR and make gd global Dirk Behme
2007-09-15  7:43 ` Wolfgang Denk [this message]
2007-09-15  9:43   ` Dirk Behme
2007-09-15 16:45     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070915074303.0DFC024669@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.