From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [GIT PULL] [ARM] Please pull from git://denx.de/git/u-boot-arm.git
Date: Sat, 15 Sep 2007 21:22:40 +0200 [thread overview]
Message-ID: <20070915192240.4CB0E247CE@gemini.denx.de> (raw)
In-Reply-To: Your message of "Tue, 11 Sep 2007 16:31:05 BST." <000001c7f488$c4d288d0$9a4d010a@Emea.Arm.com>
Dear Peter,
in message <000001c7f488$c4d288d0$9a4d010a@Emea.Arm.com> you wrote:
>
> > The following issues need to be addressed:
> > include/led.h => seems specific to the at91rm9200dk board only,
> > please move to board directory. Also, the calls to
> > these functions should be handled without #ifdef's
> > in common code. Either use existing functions hooks,
> > or weak references.
>
> Moved to asm-arm as coloured_led.h
I still would rather have this integrated into the existing status_led
driver.
> - I want to play with the coloured leds on other ARM boards sometime.
Please feel free to do so.
> > drivers/at45.c => has coding style issues - indentation of long,
> > wrapped around lines is broken.
>
> - ran Lindent on it
Actually the new version is even worse. It has many lines which are
not indented by multiple of 8 chars.
Please clean this up.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways to write error-free programs. Only the third one
works.
next prev parent reply other threads:[~2007-09-15 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 15:31 [U-Boot-Users] [GIT PULL] [ARM] Please pull from git://denx.de/git/u-boot-arm.git Peter Pearse
2007-09-15 19:22 ` Wolfgang Denk [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-14 15:08 Peter Pearse
2007-08-14 16:09 ` Wolfgang Denk
2007-08-14 16:45 ` Peter Pearse
2007-08-14 18:39 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070915192240.4CB0E247CE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.