From: Stefan Roese <sr@denx.de>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: Jean Delvare <khali@linux-fr.org>,
linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH] i2c: devtree-aware iic support for PPC4xx
Date: Sun, 16 Sep 2007 11:07:23 +0200 [thread overview]
Message-ID: <200709161107.23309.sr@denx.de> (raw)
In-Reply-To: <20070915152921.36ccbec7@localhost.localdomain>
On Saturday 15 September 2007, Vitaly Bordug wrote:
> > Where is dev->clkdiv initialized?
> >
> > My original version used iic_clkdiv() to calculate correct devider
> > based on OPB frequency. Did you even test this code?
Yes, I tested it successfully on the Sequoia eval board.
> heh, just my $0.02: the upper clearly shows one like missing, maybe during
> cleanup (since there is opb freq pulled in quote):
>
> dev->clckdiv = iic_clckdiv(*prop); or smth like that
Could be. Thanks for the hint. I'll take a look at it an resubmit.
Best regards,
Stefan
next prev parent reply other threads:[~2007-09-16 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 9:08 [PATCH] i2c: devtree-aware iic support for PPC4xx Stefan Roese
2007-09-15 10:04 ` Eugene Surovegin
2007-09-15 11:29 ` Vitaly Bordug
2007-09-16 9:07 ` Stefan Roese [this message]
2007-09-16 18:55 ` Eugene Surovegin
2007-09-15 11:36 ` Stephen Rothwell
2007-09-16 9:08 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2007-09-16 11:52 Stefan Roese
2007-09-16 16:27 ` Robert Schwebel
2007-09-16 16:37 ` Josh Boyer
2007-09-17 1:32 ` David Gibson
2007-09-16 18:53 ` Eugene Surovegin
2007-09-17 1:31 ` David Gibson
2007-09-17 5:34 ` Stefan Roese
2007-09-17 5:50 ` David Gibson
2007-09-17 6:22 ` Eugene Surovegin
2007-09-17 18:16 ` Jean Delvare
2007-09-17 19:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709161107.23309.sr@denx.de \
--to=sr@denx.de \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.