From: David Miller <davem@davemloft.net>
To: ytht.net@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet
Date: Mon, 17 Sep 2007 19:20:44 -0700 (PDT) [thread overview]
Message-ID: <20070917.192044.48396034.davem@davemloft.net> (raw)
In-Reply-To: <20070918021617.GA15540@router.lepton.home>
From: lepton <ytht.net@gmail.com>
Date: Tue, 18 Sep 2007 10:16:17 +0800
> Hi,
> In some situation, icmp_reply and ip_send_reply will send
> out packet with the wrong source addr, the following patch
> will fix this.
>
> I don't understand why we must use rt->rt_src in the current
> code, if this is a wrong fix, please correct me.
>
> Signed-off-by: Lepton Wu <ytht.net@gmail.com>
That the address is wrong is your opinion only :-)
Source address selection is a rather complex topic, and
here we are definitely purposefully using the source
address selected by the routing lookup for the reply.
next prev parent reply other threads:[~2007-09-18 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 2:16 [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet lepton
2007-09-18 2:20 ` David Miller [this message]
2007-09-18 2:26 ` YOSHIFUJI Hideaki / 吉藤英明
2007-09-18 2:48 ` lepton
2007-09-18 2:59 ` lepton
2007-09-18 3:14 ` david
2007-09-18 3:25 ` lepton
2007-09-18 14:43 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917.192044.48396034.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ytht.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.