From: "J. Bruce Fields" <bfields@fieldses.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent
Date: Sun, 16 Sep 2007 22:44:53 -0400 [thread overview]
Message-ID: <20070917024453.GA24675@fieldses.org> (raw)
In-Reply-To: <7vy7f63zr4.fsf@gitster.siamese.dyndns.org>
On Sun, Sep 16, 2007 at 05:24:31PM -0700, Junio C Hamano wrote:
> "J. Bruce Fields" <bfields@citi.umich.edu> writes:
>
> > Complain if we find 8 spaces or more in a row as part of the initial
> > whitespace on a line, and (with --whitespace=stripspace) replace such by
> > a tab.
> >
> > Well, linux's checkpatch.pl complains about this sort of thing.
>
> Some people program in Python, so I am afraid that this needs to
> be a separate option.
OK.
> Maybe it is time to redo the --whitespace options as bitmasks so
> that we can say --whitespace-fix=tab,tail,lines to pick and
> choose which kinds of breakage to fix?
OK. Or maybe keep the current commandline options and have a
whitespace-style config option someplace?
I'm afraid I won't get to either anytime soon, though, so that project's
up for grabs....
--b.
next prev parent reply other threads:[~2007-09-17 2:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 22:48 whitespace-stripping J. Bruce Fields
2007-09-16 22:49 ` [PATCH 1/3] git-apply: fix whitespace stripping J. Bruce Fields
2007-09-16 22:49 ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent J. Bruce Fields
2007-09-16 22:49 ` [PATCH 3/3] git-apply: add tests for stripping of leading and trailing whitespace J. Bruce Fields
2007-09-17 14:16 ` Krzysztof Halasa
2007-09-17 15:02 ` J. Bruce Fields
2007-09-17 23:44 ` Krzysztof Halasa
2007-09-18 0:53 ` J. Bruce Fields
2007-09-16 23:24 ` [PATCH 2/3] git-apply: complain about >=8 consecutive spaces in initial indent Martin Langhoff
2007-09-17 2:45 ` J. Bruce Fields
2007-09-17 0:24 ` Junio C Hamano
2007-09-17 2:44 ` J. Bruce Fields [this message]
2007-10-03 1:00 ` [PATCH] git-diff: " Junio C Hamano
2007-09-18 8:55 ` [PATCH 1/3] git-apply: fix whitespace stripping David Kastrup
2007-09-18 13:12 ` J. Bruce Fields
2007-09-18 14:18 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917024453.GA24675@fieldses.org \
--to=bfields@fieldses.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.