All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Hollis Blanchard <hollisb@us.ibm.com>,
	David Gibson <dwg@au1.ibm.com>
Subject: Re: [PATCH] fix xmon input on 440
Date: Sun, 16 Sep 2007 22:39:24 -0500	[thread overview]
Message-ID: <20070917033924.GA24914@lixom.net> (raw)
In-Reply-To: <1189999598.17593.18.camel@localhost.localdomain>

On Sun, Sep 16, 2007 at 10:26:37PM -0500, Josh Boyer wrote:
> On Mon, 2007-09-17 at 12:52 +1000, David Gibson wrote:
> > On Fri, Sep 14, 2007 at 03:44:47PM -0500, Hollis Blanchard wrote:
> > > Implement udbg_getc() for 440, which fixes xmon input.
> > > Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> > 
> 
> I fixed up the whitespace issues and applied it to my tree.  Oh, and
> comments don't need semi-colons ;)

Well, there's a big difference between:

	while (foo)
		/* moof */;
	return bar;

and:
	while (foo)
		/* moof */
	return bar;

:-)

  reply	other threads:[~2007-09-17  3:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 20:44 [PATCH] fix xmon input on 440 Hollis Blanchard
2007-09-17  2:52 ` David Gibson
2007-09-17  3:26   ` Josh Boyer
2007-09-17  3:39     ` Olof Johansson [this message]
2007-09-17  4:15       ` Hollis Blanchard
2007-09-17 10:58         ` Josh Boyer
2007-09-17 12:24 ` Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070917033924.GA24914@lixom.net \
    --to=olof@lixom.net \
    --cc=dwg@au1.ibm.com \
    --cc=hollisb@us.ibm.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.