All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, kwc@citi.umich.edu,
	Trond.Myklebust@netapp.com, linux-kernel@vger.kernel.org,
	smfrench@gmail.com, nfsv4@linux-nfs.org
Subject: Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous
Date: Mon, 17 Sep 2007 04:03:53 -0700	[thread overview]
Message-ID: <20070917040353.ac8dee7b.akpm@linux-foundation.org> (raw)
In-Reply-To: <16559.1190026560@redhat.com>

On Mon, 17 Sep 2007 11:56:00 +0100 David Howells <dhowells@redhat.com> wrote:

> > checkpatch generates a pile of warnings, all of which afacit are legit.
> 
> For this warning:
> 
> ERROR: need space after that ',' (ctx:WxV)
> #627: FILE: security/keys/internal.h:28:
> +#define kenter(FMT, ...) no_printk("==> %s("FMT")\n",__FUNCTION__ ,##__VA_ARGS__)
> 
>                                                                    ^
> 
> This is with good reason.  Some versions of cpp get the ## resolution "wrong"
> if __VA_ARGS__ is empty (ie: there are no arguments to the macro that
> correspond to the "...").  This can be worked around by abutting the "," the
> "##" and the "__VA_ARGS__" with no spaces, and inserting a space before the
> comma.

Tell me about it - I fixed that about 10000000000 times.  Then we upped the
minimum required gcc version so it is no longer a problem.

  reply	other threads:[~2007-09-17 11:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 14:25 [PATCH] KEYS: Make request_key() and co fundamentally asynchronous David Howells
2007-09-14 23:59 ` Andrew Morton
2007-09-17 10:56   ` David Howells
2007-09-17 11:03     ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-17 13:17 David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070917040353.ac8dee7b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=dhowells@redhat.com \
    --cc=kwc@citi.umich.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=smfrench@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.