All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Scott Merritt" <alsauser@pragmasoft.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: SALSA Lib 0.0.11 - pcm_drain
Date: Mon, 17 Sep 2007 09:32:43 -0400	[thread overview]
Message-ID: <20070917093243.1cb6268e.alsauser@pragmasoft.com> (raw)
In-Reply-To: <s5hmyvleahs.wl%tiwai@suse.de>

On Mon, 17 Sep 2007 14:34:39 +0200
Takashi Iwai <tiwai@suse.de> wrote:

> At Sun, 16 Sep 2007 19:01:32 -0400,
> J. Scott Merritt wrote:
> > 
> > In salsa-lib 0.0.11, pcm-macros.h : line 229
> > 
> > snd_pcm_drain calls the ioctl with SNDRV_PCM_IOCTL_DROP.
> > (seemingly confusing -drop- with -drain-)
> > 
> > Is there any reason that this shouldn't be changed to
> > call the ioctl with SNDRV_PCM_IOCTL_DRAIN ?
> 
> Sure, it's a typo :)
> 
> Fixed and released as 0.0.12 now.  Thanks!
> 
> 
> Takashi

Thanks Takashi,

I do not yet see 0.0.12 on the FTP server
(ftp.suse.com/pub/people/tiwai/salsa-lib), but I'm sure
it will be there shortly.

However, if you are preparing another SALSA release, you might
also want to consider including:

pcm->stream = stream;

somewhere around line 133 in pcm.c (as per my message
snd_pcm_avail_update on 14-Sep-2007).

Thanks, Scott.

  reply	other threads:[~2007-09-17 13:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-16 23:01 SALSA Lib 0.0.11 - pcm_drain J. Scott Merritt
2007-09-17 12:34 ` Takashi Iwai
2007-09-17 13:32   ` J. Scott Merritt [this message]
2007-09-17 13:32     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070917093243.1cb6268e.alsauser@pragmasoft.com \
    --to=alsauser@pragmasoft.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.