From: Christoph Hellwig <hch@lst.de>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] simplify validata_fields
Date: Tue, 18 Sep 2007 05:56:16 +0200 [thread overview]
Message-ID: <20070918035616.GA12857@lst.de> (raw)
In-Reply-To: <46EF4C51.5060503@sgi.com>
On Tue, Sep 18, 2007 at 01:56:01PM +1000, Lachlan McIlroy wrote:
> Can we drop the i_size_read() check and just call i_size_write()?
> The work we may not do by not calling i_size_write() we have to do
> in i_size_read() anyway, sometimes doing the work twice. And we
> get to lose another stack variable.
Sounds good to me, but I'd prefer to keep it in a separate patch
so this is just the mechanical removal of the xfs_getattr call.
I'll send a separate patch for it today or tomorrow.
next prev parent reply other threads:[~2007-09-18 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 16:27 [PATCH 1/4] simplify validata_fields Christoph Hellwig
2007-09-18 3:56 ` Lachlan McIlroy
2007-09-18 3:56 ` Christoph Hellwig [this message]
2007-09-18 5:09 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918035616.GA12857@lst.de \
--to=hch@lst.de \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.