From: Alan Cox <alan@redhat.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Mikael Pettersson <mikpe@it.uu.se>,
Jeff Norden <jeff@math.tntech.edu>,
alan@redhat.com, linux-kernel@vger.kernel.org,
Albert CC Lee <albertcc@tw.ibm.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
Date: Tue, 18 Sep 2007 05:07:15 -0400 [thread overview]
Message-ID: <20070918090715.GA13425@devserv.devel.redhat.com> (raw)
In-Reply-To: <46EE09D3.9010201@gmail.com>
On Mon, Sep 17, 2007 at 07:00:03AM +0200, Tejun Heo wrote:
> I wonder whether we should be using similar check in generic path too.
> We have quite a few cases where MWDMA ATAPI devices choking on commands
> with small transfer sizes. I don't think we'll experience significant
> performance regression with this applied and even if there is some, it's
> far better to have slightly slower working device.
>
> What do you guys think?
I think to start with someone should fix the ATAPI state machine. Stick
a BUG() in the driver if dma start is called when the atapi command data
size is zero
Alan
next prev parent reply other threads:[~2007-09-18 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 16:07 [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices Jeff Norden
2007-09-04 18:43 ` Mikael Pettersson
2007-09-06 0:39 ` Alan Cox
2007-09-17 5:00 ` Tejun Heo
2007-09-17 10:00 ` Jeff Garzik
2007-09-17 11:46 ` Tejun Heo
2007-09-18 9:14 ` Alan Cox
2007-09-18 9:07 ` Alan Cox [this message]
2007-09-11 1:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918090715.GA13425@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jeff@math.tntech.edu \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.