From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: 2.6.23-rc4-mm1 Date: Tue, 18 Sep 2007 14:51:04 +0200 Message-ID: <20070918125103.GR25592@kernel.dk> References: <20070917132819.GC25592@kernel.dk> <20070917192528E.tomof@acm.org> <20070918101840.GN25592@kernel.dk> <20070918123238X.tomof@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([87.55.233.238]:4987 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbXIRMuj (ORCPT ); Tue, 18 Sep 2007 08:50:39 -0400 Content-Disposition: inline In-Reply-To: <20070918123238X.tomof@acm.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori Cc: michaelc@cs.wisc.edu, pj@sgi.com, apw@shadowen.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, mel@csn.ul.ie, linux-scsi@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp On Tue, Sep 18 2007, FUJITA Tomonori wrote: > On Tue, 18 Sep 2007 12:18:40 +0200 > Jens Axboe wrote: > > > On Mon, Sep 17 2007, FUJITA Tomonori wrote: > > > On Mon, 17 Sep 2007 15:28:19 +0200 > > > Jens Axboe wrote: > > > > > > > On Sat, Sep 15 2007, FUJITA Tomonori wrote: > > > > > On Fri, 14 Sep 2007 21:16:35 -0700 > > > > > Paul Jackson wrote: > > > > > > > > > > > FUJITA Tomonori wrote: > > > > > > > Can you try this patch (against 2.6.23-rc4-mm1)? > > > > > > > > > > > > > > >From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001 > > > > > > > From: FUJITA Tomonori > > > > > > > Date: Mon, 10 Sep 2007 04:17:13 +0100 > > > > > > > Subject: [PATCH] qla1280: sg chaining fixes > > > > > > > > > > > > > > Signed-off-by: FUJITA Tomonori > > > > > > > --- > > > > > > > drivers/scsi/qla1280.c | 5 ++++- > > > > > > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > > > > > > > This patch works for me. > > > > > > > > > > > > I was getting the scsi errors reported earlier in > > > > > > this thread, running 2.6.23-rc4-mm1 on one of our > > > > > > big SGI Altix systems. > > > > > > > > > > > > Applying this patch fixed it, so far as I can tell, > > > > > > which is to say my system boots cleanly once again. > > > > > > > > > > Thanks for testing! > > > > > > > > > > Jens, we could enable use_sg_chaining option for qla1280. > > > > > > > > Added, thanks! > > > > > > Thanks. > > > > > > BTW, please don't forget to integrate the following patches: > > > > > > > > > - revert sg segment size ifdefs > > > > > > http://marc.info/?l=linux-scsi&m=118881264013097&w=2 > > > > > > - remove sglist_len > > > > > > http://marc.info/?l=linux-scsi&m=118907920405100&w=2 > > > > Added, and I rebased the sglist-* branches to current again. So > > everything should be fully uptodate once more. > > Thanks, here are a few more things. > > - please drop the iscsi patch since Mike has major changes to iscsi > I/O path. > > - ipr sg chaining need to be disabled since libata is not ready. > > - you can add Doug's ACK to scsi_debug patch: > > http://marc.info/?l=linux-scsi&m=118926325931801&w=2 All done. -- Jens Axboe