All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Andreas Herrmann <aherrman@arcor.de>
Cc: Yu Luming <luming.yu@intel.com>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi_video: kernel build error if !INPUT
Date: Tue, 18 Sep 2007 12:53:54 -0400	[thread overview]
Message-ID: <200709181253.54227.lenb@kernel.org> (raw)
In-Reply-To: <20070917214105.GC22458@devil>

Applied.

thanks,
-Len

On Monday 17 September 2007 17:41, Andreas Herrmann wrote:
> Commit e9dab1960ac9746fa34eff726b81635147615a79 exports ACPI
> video hotkey events via input layer. But this breaks kernel
> build if ACPI_VIDEO && !INPUT:
> 
>  LD      .tmp_vmlinux1
> drivers/built-in.o: In function `acpi_video_bus_remove':
> drivers/acpi/video.c:2007: undefined reference to `input_unregister_device'
>     ...
> 
> Add dependency to INPUT for ACPI_VIDEO to prevent this error.
> 
> Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
> ---
>  drivers/acpi/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 4875f01..9685b75 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -117,6 +117,7 @@ config ACPI_BUTTON
>  config ACPI_VIDEO
>  	tristate "Video"
>  	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
> +	depends on INPUT
>  	help
>  	  This driver implement the ACPI Extensions For Display Adapters
>  	  for integrated graphics devices on motherboard, as specified in

      reply	other threads:[~2007-09-18 16:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-17 21:41 [PATCH] acpi_video: kernel build error if !INPUT Andreas Herrmann
2007-09-18 16:53 ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709181253.54227.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=aherrman@arcor.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=luming.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.