From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Nadia Derbey <Nadia.Derbey@bull.net>,
Alexey Dobriyan <adobriyan@sw.ru>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...
Date: Tue, 18 Sep 2007 11:29:24 -0700 [thread overview]
Message-ID: <20070918182924.GF8665@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070918095715.05899d12.akpm@linux-foundation.org>
On Tue, Sep 18, 2007 at 09:57:15AM -0700, Andrew Morton wrote:
> On Tue, 18 Sep 2007 09:13:37 -0700 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > On Tue, Sep 18, 2007 at 02:24:51PM +0200, Peter Zijlstra wrote:
> > > On Tue, 18 Sep 2007 03:34:00 -0700 Andrew Morton
> > > <akpm@linux-foundation.org> wrote:
> > >
> > > > Well, it was an optimisation. spin_lock() implies rcu_read_lock(). That's
> > > > a bit dirty and we might choose to not do that.
> > >
> > > Not true for the preemptible-rcu work. All such sites should be fixed,
> > > or at the very least heavily annotated.
> >
> > What he said!!!
> >
>
> What he said!
>
> How are you going to find all such sites?
A first step would be to look for patches in -rt that add rcu_read_lock()
or friends. A second step would be to look for rcu_dereference() without
an enclosing rcu_read_lock(), rcu_read_lock_bh(), or preempt_disable().
Beyond a certain point, this reduces to the problem of finding places
where spin_lock() was omitted, right?
Thanx, Paul
next prev parent reply other threads:[~2007-09-18 18:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 9:17 2.6.23-rc6-mm1: IPC: sleeping function called Alexey Dobriyan
2007-09-18 9:42 ` Andrew Morton
2007-09-18 10:17 ` Andrew Morton
2007-09-18 10:30 ` Nadia Derbey
2007-09-18 10:34 ` Andrew Morton
[not found] ` <20070918142451.418b3b51@twins>
2007-09-18 16:13 ` Paul E. McKenney
2007-09-18 16:57 ` Andrew Morton
2007-09-18 18:29 ` Paul E. McKenney [this message]
2007-09-18 19:41 ` Peter Zijlstra
2007-09-18 20:26 ` [PATCH 1/2] lockdep: annotate rcu_read_lock() Peter Zijlstra
2007-09-18 20:27 ` [RFC][PATCH 2/2] lockdep: rcu_dereference() vs rcu_read_lock() Peter Zijlstra
2007-09-18 21:21 ` Paul E. McKenney
2007-09-18 10:27 ` 2.6.23-rc6-mm1: IPC: sleeping function called Andrew Morton
2007-09-18 10:32 ` Alexey Dobriyan
2007-09-18 14:55 ` Nadia Derbey
2007-09-18 17:01 ` Andrew Morton
2007-09-21 9:18 ` Nadia Derbey
2007-09-19 14:07 ` Jarek Poplawski
2007-09-20 6:24 ` Nadia Derbey
2007-09-20 7:28 ` Jarek Poplawski
2007-09-20 8:21 ` Jarek Poplawski
2007-09-20 8:52 ` Nadia Derbey
2007-09-20 13:08 ` Nadia Derbey
2007-09-20 13:26 ` Jarek Poplawski
2007-09-21 8:44 ` Jarek Poplawski
2007-09-21 10:11 ` Nadia Derbey
2007-09-21 11:03 ` Jarek Poplawski
2007-09-21 11:15 ` Jarek Poplawski
2007-09-24 6:54 ` Jarek Poplawski
2007-09-24 7:43 ` Jarek Poplawski
2007-09-24 8:18 ` Nadia Derbey
2007-09-24 9:50 ` Nadia Derbey
2007-09-25 11:47 ` Jarek Poplawski
2007-09-26 6:13 ` Jarek Poplawski
2007-09-20 13:19 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918182924.GF8665@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Nadia.Derbey@bull.net \
--cc=adobriyan@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.