From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [patch lm-sensors 2.10.4] i2cdetect mislabels PEC
Date: Wed, 19 Sep 2007 07:59:45 +0000 [thread overview]
Message-ID: <20070919095945.2d2263bb@hyperion.delvare> (raw)
In-Reply-To: <20070917205024.0A35D230DBC@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Hi David,
On Tue, 18 Sep 2007 15:45:36 -0700, David Brownell wrote:
> > > - .name = "SMBus PEC" },
> > > + .name = "SMBus PEC in Hardware" },
> >
> > I agree that the current situation is confusing, I had noticed this
> > already when reworking the PEC support in 2.6.15, but postponed fixing
> > it.
> >
> > However, I don't think that what you proposed is the proper fix. We
> > don't care whether PEC is implemented in hardware or software. What
> > really matters is whether it is implemented at all, or not. So I'd
> > rather rename I2C_FUNC_SMBUS_HWPEC_CALC to I2C_FUNC_SMBUS_PEC, and have
> > i2c-algo-bit and other drivers declare that they support it. What do
> > you think?
>
> How about just not exposing that capability from i2cdetect at all?
>
> There's a software implementation that's always available. Whether
> that's used, or a (presumably accelerated) hardware one is used is
> purely an implementation issue, not an interface issue that a driver
> would have any reason to care about.
This is not true. Software PEC support is only available for adapters
emulating SMBus support using I2C-level messaging (e.g. i2c-algo-bit.)
For non-I2C SMBus masters, PEC support is there only if the hardware
explicitly supports it, it cannot be emulated. For example the Intel
ICH3 can't do PEC. That's the reason why having a functionality bit for
SMBus PEC makes sense.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-09-19 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 20:50 [lm-sensors] [patch lm-sensors 2.10.4] i2cdetect mislabels PEC David Brownell
2007-09-18 21:45 ` Jean Delvare
2007-09-18 22:45 ` David Brownell
2007-09-19 7:59 ` Jean Delvare [this message]
2007-09-19 21:55 ` David Brownell
2007-09-20 11:02 ` Jean Delvare
2007-09-21 17:11 ` David Brownell
2007-09-23 21:01 ` Jean Delvare
2007-10-03 19:23 ` David Brownell
2007-10-04 14:45 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919095945.2d2263bb@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.