From: Christoph Hellwig <hch@lst.de>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] kill unnessecary ioops indirection
Date: Wed, 19 Sep 2007 13:03:18 +0200 [thread overview]
Message-ID: <20070919110318.GA3703@lst.de> (raw)
In-Reply-To: <46F07E79.8090605@sgi.com>
On Wed, Sep 19, 2007 at 11:42:17AM +1000, Lachlan McIlroy wrote:
> >vn_to_inode()/vn_from_inode() are no-ops nowdays, btw.
> Yeah I know - that's why I'd like to get rid of them. They make the
> code ugly and give the impression we need to work with two different
> objects. There's lots of places where we declare an extra pointer on
> the stack when we don't need to. Anyway that's fodder for another
> patch, this patch looks good now.
Yes, eventually we should get rid of them. I have a patch for the
functions prototypes in xfs_vnodeops.h somewhere, and fixing the dmapi
interface to avoid vnodes is also high on my todo list.
prev parent reply other threads:[~2007-09-19 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 16:28 [PATCH 1/2] kill unnessecary ioops indirection Christoph Hellwig
[not found] ` <46EF661C.4030500@sgi.com>
2007-09-18 19:23 ` Christoph Hellwig
2007-09-19 1:42 ` Lachlan McIlroy
2007-09-19 11:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919110318.GA3703@lst.de \
--to=hch@lst.de \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.