From: 'Christoph Hellwig' <hch@infradead.org>
To: Alexander Indenbaum <baum@tehutinetworks.net>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
jeff@garzik.org, davem@davemloft.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, 'Nadav Shemer' <nadav@tehutinetworks.net>,
'Andy Gospodarek' <andy@greyhouse.net>
Subject: Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters
Date: Wed, 19 Sep 2007 16:52:58 +0100 [thread overview]
Message-ID: <20070919155258.GA14850@infradead.org> (raw)
In-Reply-To: <20070919104438.B1FF775CAD@mail.tehutinetworks.co.il>
On Wed, Sep 19, 2007 at 12:44:33PM +0200, Alexander Indenbaum wrote:
> > - please don't redefine the dma mask constants
> > - please use the firmware loader instead of mebedding a firmware
> > image
>
> Could you give us some pointers to docs and examples of "firmware loader"?
> I'm not sure I'm familiar with such mechanism in Linux kernel.
Documentation/firmware_class/ in the kernel tree has the documentation
for it. Grep the kernel tree for request_firmware to find various users.
> Putting dual-port issue aside, could you elaborate what is the problem in
> your opinion in bdx_remove() implementation? What is wrong with calling
> free_netdev() right after unregister_netdev()? Could you provide pointers
> for docs and examples to correct PCI network device remove interface
> implementation?
free_netdev can only be called if you're sure you don't reference your
netdevice anymore. Most notably that means you need to call free_irq
first.
next prev parent reply other threads:[~2007-09-19 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 16:40 [PATCH] tehuti: driver for Tehuti 10GbE network adapters Andy Gospodarek
2007-09-14 15:36 ` Andy Gospodarek
2007-09-14 15:59 ` Jeff Garzik
2007-09-16 21:14 ` Andrew Morton
2007-09-17 16:54 ` Alexander Indenbaum
2007-09-18 9:47 ` Christoph Hellwig
2007-09-19 10:44 ` Alexander Indenbaum
2007-09-19 15:52 ` 'Christoph Hellwig' [this message]
2007-09-19 17:37 ` Alexander Indenbaum
2007-09-19 17:41 ` 'Christoph Hellwig'
2007-09-19 19:28 ` Alexander Indenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919155258.GA14850@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=davem@davemloft.org \
--cc=jeff@garzik.org \
--cc=nadav@tehutinetworks.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.