All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386/PAE: avoid temporarily inconsistent pte-s
Date: Wed, 19 Sep 2007 18:17:30 +0200	[thread overview]
Message-ID: <200709191817.30569.ak@suse.de> (raw)
In-Reply-To: <46F16779.76E4.0078.0@novell.com>

On Wednesday 19 September 2007 18:16:25 Jan Beulich wrote:
> >>> Andi Kleen <ak@suse.de> 19.09.07 18:09 >>>
> >On Wednesday 19 September 2007 16:39:39 Jan Beulich wrote:
> >> One more of these issues (which were considered fixed a few releases
> >> back): Other than on x86-64, i386 allows set_fixmap() to replace
> >> already present mappings. Consequently, on PAE, care must be taken to
> >> not update the high half of a pte while the low half is still holding
> >> the old value.
> >
> >Hmm perhaps it would be better to just forbid it on i386 too.
> >Do you know who uses it?
> 
> PCI's mmconfig accessor. One could of course make it call clear_fixmap() prior
> to establishing a new mapping, but I thought that was not intended and is the
> reason for allowing this.

Makes sense. Applied thanks.

-Andi


      reply	other threads:[~2007-09-19 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 14:39 [PATCH] i386/PAE: avoid temporarily inconsistent pte-s Jan Beulich
2007-09-19 16:09 ` Andi Kleen
2007-09-19 16:16   ` Jan Beulich
2007-09-19 16:17     ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709191817.30569.ak@suse.de \
    --to=ak@suse.de \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.