From: Simon Hausmann <simon@lst.de>
To: David Brown <git@davidb.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [git-p4] Detect exec bit in more cases.
Date: Wed, 19 Sep 2007 21:03:50 +0200 [thread overview]
Message-ID: <200709192103.53526.simon@lst.de> (raw)
In-Reply-To: <119022570352-git-send-email-git@davidb.org>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On Wednesday 19 September 2007 20:15:03 David Brown wrote:
> git-p4 was missing the execute bit setting if the file had other attribute
> bits set.
> ---
> contrib/fast-import/git-p4 | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index adaaae6..50850b8 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -932,7 +932,10 @@ class P4Sync(Command):
> data = file['data']
>
> mode = "644"
> - if file["type"].startswith("x"):
> + if (file["type"].startswith("x") or
> + file["type"].startswith("cx") or
> + file["type"].startswith("kx") or
> + file["type"].startswith("ux")):
> mode = "755"
> elif file["type"] == "symlink":
> mode = "120000"
I'm fine with this, so unless you find a better way:
Acked-By: Simon Hausmann <simon@lst.de>
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-19 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 18:15 [PATCH] [git-p4] Detect exec bit in more cases David Brown
2007-09-19 19:03 ` Simon Hausmann [this message]
2007-09-19 19:14 ` David Brown
2007-09-19 19:31 ` Dana How
2007-09-19 19:49 ` David Brown
2007-09-20 15:16 ` David Brown
2007-09-20 22:53 ` Junio C Hamano
2007-09-21 10:20 ` Simon Hausmann
2007-09-21 21:15 ` Junio C Hamano
2007-09-21 21:24 ` David Brown
2007-09-24 6:20 ` Simon Hausmann
2007-09-19 20:12 ` David Brown
2007-09-19 21:03 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709192103.53526.simon@lst.de \
--to=simon@lst.de \
--cc=git@davidb.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.