From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Emil Medve <Emilian.Medve@freescale.com>
Cc: paulus@samba.org, kumar.gala@freescale.com,
linuxppc-dev@ozlabs.org, linuxppc-embedded@ozlabs.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] [POWERPC] Fix build errors when BLOCK=n
Date: Wed, 19 Sep 2007 22:00:56 +0200 [thread overview]
Message-ID: <200709192200.56605.bzolnier@gmail.com> (raw)
In-Reply-To: <1190227172-593-1-git-send-email-Emilian.Medve@Freescale.com>
On Wednesday 19 September 2007, Emil Medve wrote:
> These are the symptom error messages:
>
> CC arch/powerpc/kernel/setup_32.o
> In file included from include/linux/blkdev.h:17,
> from include/linux/ide.h:13,
> from arch/powerpc/kernel/setup_32.c:13:
> include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list
> include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/bsg.h:71: warning: 'struct request_queue' declared inside parameter list
> In file included from arch/powerpc/kernel/setup_32.c:13:
> include/linux/ide.h:857: error: field 'wrq' has incomplete type
>
> CC arch/powerpc/kernel/ppc_ksyms.o
> In file included from include/linux/blkdev.h:17,
> from include/linux/ide.h:13,
> from arch/powerpc/kernel/ppc_ksyms.c:15:
> include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list
> include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/bsg.h:71: warning: 'struct request_queue' declared inside parameter list
> In file included from arch/powerpc/kernel/ppc_ksyms.c:15:
> include/linux/ide.h:857: error: field 'wrq' has incomplete type
>
> The fix tries to use the smallest scope CONFIG_* symbols that will fix the build
> problem. In this case <linux/ide.h> needs to be included only if IDE=y or
> IDE=m were selected. Also, ppc_ide_md is needed only if BLK_DEV_IDE=y or
> BLK_DEV_IDE=m
>
> Moved the EXPORT_SYMBOL(ppc_ide_md) from ppc_ksysms.c next to its declaration
> in setup_32.c
>
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
looks OK for me
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Emil Medve <Emilian.Medve@freescale.com>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
kumar.gala@freescale.com, paulus@samba.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH v2] [POWERPC] Fix build errors when BLOCK=n
Date: Wed, 19 Sep 2007 22:00:56 +0200 [thread overview]
Message-ID: <200709192200.56605.bzolnier@gmail.com> (raw)
In-Reply-To: <1190227172-593-1-git-send-email-Emilian.Medve@Freescale.com>
On Wednesday 19 September 2007, Emil Medve wrote:
> These are the symptom error messages:
>
> CC arch/powerpc/kernel/setup_32.o
> In file included from include/linux/blkdev.h:17,
> from include/linux/ide.h:13,
> from arch/powerpc/kernel/setup_32.c:13:
> include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list
> include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/bsg.h:71: warning: 'struct request_queue' declared inside parameter list
> In file included from arch/powerpc/kernel/setup_32.c:13:
> include/linux/ide.h:857: error: field 'wrq' has incomplete type
>
> CC arch/powerpc/kernel/ppc_ksyms.o
> In file included from include/linux/blkdev.h:17,
> from include/linux/ide.h:13,
> from arch/powerpc/kernel/ppc_ksyms.c:15:
> include/linux/bsg.h:67: warning: 'struct request_queue' declared inside parameter list
> include/linux/bsg.h:67: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/bsg.h:71: warning: 'struct request_queue' declared inside parameter list
> In file included from arch/powerpc/kernel/ppc_ksyms.c:15:
> include/linux/ide.h:857: error: field 'wrq' has incomplete type
>
> The fix tries to use the smallest scope CONFIG_* symbols that will fix the build
> problem. In this case <linux/ide.h> needs to be included only if IDE=y or
> IDE=m were selected. Also, ppc_ide_md is needed only if BLK_DEV_IDE=y or
> BLK_DEV_IDE=m
>
> Moved the EXPORT_SYMBOL(ppc_ide_md) from ppc_ksysms.c next to its declaration
> in setup_32.c
>
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
looks OK for me
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
next prev parent reply other threads:[~2007-09-19 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 18:39 [PATCH v2] [POWERPC] Fix build errors when BLOCK=n Emil Medve
2007-09-19 20:00 ` Bartlomiej Zolnierkiewicz [this message]
2007-09-19 20:00 ` Bartlomiej Zolnierkiewicz
2007-09-20 0:58 ` Paul Mackerras
2007-09-20 0:58 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709192200.56605.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=Emilian.Medve@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.