From: Alasdair G Kergon <agk@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Guido Guenther <agx@sigxcpu.org>,
dm-devel@redhat.com
Subject: Re: dm-ioctl on amd64 with 32bit userspace
Date: Thu, 20 Sep 2007 02:24:48 +0100 [thread overview]
Message-ID: <20070920012448.GL18444@agk.fab.redhat.com> (raw)
In-Reply-To: <20070919172650.72df609f.akpm@linux-foundation.org>
On Wed, Sep 19, 2007 at 05:26:50PM -0700, Andrew Morton wrote:
> I don't understand why people aren't running around with their hair on fire
> over this bug. Is everyone running 64-bit dmsetup, or what?
1) There probably aren't many users in a mixed 32/64 environment;
2) The operations triggering the problem are fairly uncommon.
It's still a surprise nobody noticed this before (with lvrename) as it looks
like this has always been broken.
This particular patch looks inadequate though - fixes it for some people
but breaks it for others? Other parts of this code call alignment
functions and store offsets explicitly and probably something similar
should be happening here - with userspace libdevmapper changes too.
Let me consider the alternatives and their consequences.
> This looks like 2.6.22 and 2.6.23 material to me. Alasdair?
When we have a complete fix, yes.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-09-20 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 16:57 dm-ioctl on amd64 with 32bit userspace Guido Guenther
2007-09-20 0:26 ` Andrew Morton
2007-09-20 1:24 ` Alasdair G Kergon [this message]
2007-09-20 7:07 ` Guido Guenther
2007-09-20 15:32 ` Alasdair G Kergon
2007-09-20 18:46 ` Guido Guenther
[not found] ` <20070929132754.GA19089@bogon.ms20.nix>
[not found] ` <20071002010519.GB18444@agk.fab.redhat.com>
[not found] ` <20071002071647.GA11183@bogon.ms20.nix>
2007-10-04 17:28 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920012448.GL18444@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=agx@sigxcpu.org \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.