From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Jackson Subject: Re: Kernel text size with pid namespace Date: Thu, 20 Sep 2007 04:04:06 -0700 Message-ID: <20070920040406.57e40ece.pj@sgi.com> References: <20070920001644.GA14880@us.ibm.com> <46F239B2.8080500@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46F239B2.8080500-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Pavel Emelyanov Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, mpm-VDJrAJ4Gl5ZBDgjK7y7TUQ@public.gmane.org List-Id: containers.vger.kernel.org > > functions are used in process creation/termination, we would need to > > keep them inline, when optimizing for performance. > > I'd keep them inline for performance reasons. As Matt Mackall explained more carefully in his reply, it's no longer clear that inlining is best for performance in as many situations as it was the past. Cache footprint size tends to dominate performance on present day processors. See also Matt's comments on the NULL struct pid check. Getting rid of conditional jumps may be the more important performance issue here. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401