From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 05/15] ocfs2: Pass raw u64 to filldir
Date: Thu Sep 20 11:41:24 2007 [thread overview]
Message-ID: <20070920184047.GH30391@tasint.org> (raw)
In-Reply-To: <200709192012.l8JKCGhF012172@agmgw2.us.oracle.com>
On Mon, Sep 10, 2007 at 05:30:26PM -0700, Mark Fasheh wrote:
> filldir_t can take this, so don't turn de->inode into a 32 bit value. Right
> now this doesn't make a difference since no ocfs2 inodes overflow that, but
> it could be a nasty surprise later on if some kernel code is calling
> ocfs2_dir_foreach_blk() and expecting real inode numbers back...
How come we don't have inodes overflowing 32bits? Is this a
limit imposed elsewhere? Refresh my (swiss cheese) memory :-)
I actually think that the -EOVERFLOW from filldir(7) is better
than our truncated ino, so I still say
Signed-off-by: Joel Becker <joel.becker@oracle.com>
--
Viro's Razor:
Any race condition, no matter how unlikely, will occur just
often enough to bite you.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2007-09-20 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 13:12 [Ocfs2-devel] [PATCH 05/15] ocfs2: Pass raw u64 to filldir Mark Fasheh
2007-09-20 11:41 ` Joel Becker [this message]
2007-09-20 12:05 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920184047.GH30391@tasint.org \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.