All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: Vote message and response structures packed
Date: Thu Sep 20 12:05:24 2007	[thread overview]
Message-ID: <20070920190520.GD21356@ca-server1.us.oracle.com> (raw)
In-Reply-To: <11903111882211-git-send-email-sunil.mushran@oracle.com>

Thanks, applied.
	--Mark

On Thu, Sep 20, 2007 at 10:59:48AM -0700, Sunil Mushran wrote:
> The ocfs2_vote_msg and ocfs2_response_msg structs needed to be
> packed to ensure similar sizeofs in 32-bit and 64-bit arches.
> 
> Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
> ---
>  fs/ocfs2/vote.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/vote.c b/fs/ocfs2/vote.c
> index 66a13ee..c053585 100644
> --- a/fs/ocfs2/vote.c
> +++ b/fs/ocfs2/vote.c
> @@ -66,7 +66,7 @@ struct ocfs2_vote_msg
>  {
>  	struct ocfs2_msg_hdr v_hdr;
>  	__be32 v_reserved1;
> -};
> +} __attribute__ ((packed));
>  
>  /* Responses are given these values to maintain backwards
>   * compatibility with older ocfs2 versions */
> @@ -78,7 +78,7 @@ struct ocfs2_response_msg
>  {
>  	struct ocfs2_msg_hdr r_hdr;
>  	__be32 r_response;
> -};
> +} __attribute__ ((packed));
>  
>  struct ocfs2_vote_work {
>  	struct list_head   w_list;
> -- 
> 1.5.2.5
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com

      reply	other threads:[~2007-09-20 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-20 10:59 [Ocfs2-devel] ocfs2: Vote message and response structures packed Sunil Mushran
2007-09-20 10:59 ` [Ocfs2-devel] [PATCH 1/1] " Sunil Mushran
2007-09-20 12:05   ` Mark Fasheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070920190520.GD21356@ca-server1.us.oracle.com \
    --to=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.