From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 10/15] ocfs2: Cleanup dirent size check
Date: Thu Sep 20 13:44:52 2007 [thread overview]
Message-ID: <20070920204449.GE21356@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20070920191400.GM30391@tasint.org>
On Thu, Sep 20, 2007 at 12:14:00PM -0700, Joel Becker wrote:
> On Thu, Sep 13, 2007 at 04:29:01PM -0700, Mark Fasheh wrote:
> > The check to see if a new dirent would fit in an old one is pretty ugly, and
> > it's done at least twice. Clean things up by putting this in it's own
> > easier-to-read function.
> >
> > Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
>
> de_really_needed sounds like it's the new needed, which confused me
> (de_really_needed + new_rec_len sounds like "new needed + new needed",
> which of course makes no sense). Can you rename de_really_needed to
> de_really_used, de_old_used, or de_old_needed? That captures the sense
> of "how much space in the old dirent is actually used".
Yeah, that variable naming even confuses me when I look at it :(
I'm going to spin the wheel of variable names and land at....
de_really_used!
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
prev parent reply other threads:[~2007-09-20 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 13:12 [Ocfs2-devel] [PATCH 10/15] ocfs2: Cleanup dirent size check Mark Fasheh
2007-09-20 12:14 ` Joel Becker
2007-09-20 13:44 ` Mark Fasheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920204449.GE21356@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.