All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 14/15] ocfs2: Read support for directories with inline data
Date: Thu Sep 20 17:14:41 2007	[thread overview]
Message-ID: <20070921001404.GH3490@tasint.org> (raw)
In-Reply-To: <20070921000454.GH21356@ca-server1.us.oracle.com>

On Thu, Sep 20, 2007 at 05:04:54PM -0700, Mark Fasheh wrote:
> On Thu, Sep 20, 2007 at 04:47:40PM -0700, Joel Becker wrote:
> > 	Isn't this function basically the center of foreach_blk_el()?
> 
> It's deceptive. Some parts are similar, but many checks are different or
> don't exist in one version over another. The looping is slightly different
> too. The extent based code handles readahead, while that doesn't make sense
> for inline-data, etc, etc.

	Ok, that's what I was curious about.
 
> I managed to consolidate most of the other dir functions though, which I
> was happy about.

	I noticed that :-)

Joel

-- 

"Here's something to think about:  How come you never see a headline
 like ``Psychic Wins Lottery''?"
	- Jay Leno

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2007-09-20 17:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 13:12 [Ocfs2-devel] [PATCH 14/15] ocfs2: Read support for directories with inline data Mark Fasheh
2007-09-20 16:48 ` Joel Becker
2007-09-20 17:04   ` Mark Fasheh
2007-09-20 17:14     ` Joel Becker [this message]
2007-09-20 17:15       ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070921001404.GH3490@tasint.org \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.