From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 3/6] virtio net driver Date: Fri, 21 Sep 2007 12:48:11 +0200 Message-ID: <200709211248.11783.borntraeger@de.ibm.com> References: <1190289808.7262.223.camel@localhost.localdomain> <1190290369.7262.231.camel@localhost.localdomain> <1190290495.7262.235.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: lguest , Herbert Xu , Jeff Garzik , virtualization To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <1190290495.7262.235.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Am Donnerstag, 20. September 2007 schrieb Rusty Russell: > The network driver uses *two* virtqueues: one for input packets and > one for output packets. This has nice locking properties (ie. we > don't do any for recv vs send). [...] > 3) Resolve freeing of old xmit skbs (someone sent patch IIRC?) Yes, that was me. I am quite busy at the moment but I will send a refreshed patch soon. The most annoying fact of my current patch is, that I have to add locking. (Because of the only one operation per virtqueue at a time rule) [...] > +struct virtnet_info > +{ > + struct virtqueue_ops *vq_ops; > + struct virtqueue *vq_recv; > + struct virtqueue *vq_send; > + struct net_device *ndev; This is only a matter of taste, but I like netdev or dev more than ndev. [...] Everything else looks sane. 20-minutes-code-review-by: Christian Borntraeger Christian ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/