From: Len Brown <lenb@kernel.org>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: linux-acpi@vger.kernel.org, abelay@novell.com
Subject: Re: [PATCH] Configure cpuidle governors by default
Date: Fri, 21 Sep 2007 22:23:57 -0400 [thread overview]
Message-ID: <200709212223.57886.lenb@kernel.org> (raw)
In-Reply-To: <20070913203917.GA1183@linux-os.sc.intel.com>
Applied.
Hey, what a great idea:-)
thanks,
-Len
On Thursday 13 September 2007 16:39, Venki Pallipadi wrote:
>
> Quoting Len "Do not give an option to users to shoot themselves in the foot".
>
> Remove the configurability of ladder and menu governors as they are
> needed for default policy of cpuidle. That way users will not be able to
> have cpuidle without any policy loosing all C-state power savings.
>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> Index: linux-2.6.23-rc6/drivers/cpuidle/Kconfig
> ===================================================================
> --- linux-2.6.23-rc6.orig/drivers/cpuidle/Kconfig
> +++ linux-2.6.23-rc6/drivers/cpuidle/Kconfig
> @@ -1,4 +1,3 @@
> -menu "CPU idle PM support"
>
> config CPU_IDLE
> bool "CPU idle PM support"
> @@ -10,30 +9,13 @@ config CPU_IDLE
> If you're using a mobile platform that supports CPU idle PM (e.g.
> an ACPI-capable notebook), you should say Y here.
>
> -if CPU_IDLE
> -
> -comment "Governors"
> -
> config CPU_IDLE_GOV_LADDER
> - tristate "'ladder' governor"
> + bool
> depends on CPU_IDLE
> default y
> - help
> - This cpuidle governor promotes and demotes through the supported idle
> - states using residency time and bus master activity as metrics. This
> - algorithm was originally introduced in the old ACPI processor driver.
>
> config CPU_IDLE_GOV_MENU
> - tristate "'menu' governor"
> + bool
> depends on CPU_IDLE && NO_HZ
> default y
> - help
> - This cpuidle governor evaluates all available states and chooses the
> - deepest state that meets all of the following constraints: BM activity,
> - expected time until next timer interrupt, and last break event time
> - delta. It is designed to minimize power consumption. Currently
> - dynticks is required.
> -
> -endif # CPU_IDLE
>
> -endmenu
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2007-09-22 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 20:39 [PATCH] Configure cpuidle governors by default Venki Pallipadi
2007-09-13 21:30 ` Moore, Robert
2007-09-22 2:23 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709212223.57886.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=abelay@novell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.