From: David Chinner <dgc@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: David Chinner <dgc@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 4 of 4] Restore ihashsize mount option as deprecated
Date: Sun, 23 Sep 2007 17:57:56 +1000 [thread overview]
Message-ID: <20070923075756.GP995458@sgi.com> (raw)
In-Reply-To: <46F4390A.5070407@sandeen.net>
On Fri, Sep 21, 2007 at 04:35:06PM -0500, Eric Sandeen wrote:
> David Chinner wrote:
>
> > The ihashsize option should remain so that filesystems with
> > this set don't fail to mount. Ignore the mount option value
> > and issue a deprecation warning to syslog.
> >
> > Update the ihashsize mount option documentation to indicate this
> > behaviour. Update the ikeep/noikeep mount option documentation
> > while we are there.
> >
> >
> Hm, but shouldn't some of these mount struct items go too, now?
Yes. I thought I killed them - must have missed them in some
of the patch juggling I had to do at one point.
> (I may go looking for more unused struct members for fun if I have
> time...)
>
> -------------
>
> Remove unused xfs_mount and xfs_mount_args structure members
> post radix-tree conversion.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Looks ok to me...
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-09-23 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 11:45 [PATCH 4 of 4] Restore ihashsize mount option as deprecated David Chinner
[not found] ` <46F4390A.5070407@sandeen.net>
2007-09-23 7:57 ` David Chinner [this message]
2007-09-23 10:00 ` Christoph Hellwig
[not found] ` <46F67BD3.8050706@sandeen.net>
2007-09-23 22:05 ` Mark Goodwin
2007-09-23 22:38 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070923075756.GP995458@sgi.com \
--to=dgc@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.