All of lore.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Steve Wise <swise@opengridcomputing.com>
Cc: netdev@vger.kernel.org
Subject: Re: pktgen question
Date: Sun, 23 Sep 2007 21:28:04 +0400	[thread overview]
Message-ID: <20070923172803.GA11997@2ka.mipt.ru> (raw)
In-Reply-To: <46F6905C.6030309@opengridcomputing.com>

Hi Steve.

On Sun, Sep 23, 2007 at 11:12:12AM -0500, Steve Wise (swise@opengridcomputing.com) wrote:
> The pktgen module provides a way to "clone" the skb its using for 
> transmission, and allows passing N clones of the originally created skb 
> to the driver under test.    However, it doesn't really use skb_clone(), 
> but rather it just bumps the skb->users count for each "clone" and 
> passes the same skb ptr to the driver.
> 
> Q: Is that a valid use of skb->users or should pktgen really be cloning 
> the skbuff?

It's a hack, but since skb is owned by pktgen only (no copies in some
outside queues or some other access) it is allowed just to bump reference
counter (i.e. 'share' skb in usual notation).

-- 
	Evgeniy Polyakov

  reply	other threads:[~2007-09-23 18:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 16:12 pktgen question Steve Wise
2007-09-23 17:28 ` Evgeniy Polyakov [this message]
2007-09-23 17:55   ` Steve Wise
2007-09-23 18:18     ` jamal
2007-09-24  6:30       ` Ben Greear
2007-09-24 13:54         ` Steve Wise
2007-09-24 14:39           ` Ben Greear
2007-09-24 15:00             ` Steve Wise
2007-09-24 15:37               ` Ben Greear
2007-09-24 18:02                 ` Rick Jones
2007-09-24 18:22                   ` Ben Greear
2007-10-08 21:43                     ` Steve Wise
2007-10-08 21:57                       ` Ben Greear
2007-10-08 22:22                         ` David Miller
2007-10-08 22:46                           ` Steve Wise
2007-10-08 22:54                             ` David Miller
2007-09-24 15:42           ` Robert Olsson
2007-09-24 17:40           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070923172803.GA11997@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.