All of lore.kernel.org
 help / color / mirror / Atom feed
From: stefan@mdy.univie.ac.at (Stefan Boresch)
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi_transport_spi: fix domain validation failure from incorrect width setting
Date: Mon, 24 Sep 2007 14:10:04 +0200	[thread overview]
Message-ID: <20070924121004.GR1606@loop.mdy.univie.ac.at> (raw)
In-Reply-To: <1190468409.3347.3.camel@localhost.localdomain>


Dear James!

Sorry for replying so late!

On Sat, Sep 22, 2007 at 08:40:09AM -0500, James Bottomley wrote:
> The previous patch was a bit non-standard because it actually adjusted
> the user setting max_width.  This would mean that if the user replaced
> the cable and then re-ran domain validation, it still wouldn't try wide
> transfers, which is wrong.
> 
> The attached patch fixes the problem by physically nailing the wide
> setting to what it deduces it should be for the whole of Domain
> Validation.
> 
> James
> 
> diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
[snip]

A self-compiled kernel based on the Ubuntu "gutsy" kernel sources
(linux-source-2.6.22_2.6.22-12.36_all.deb, for whatever that is worth) boots
successfully, after applying your patch (which applied cleanly)

Thanks so much for your help,

Stefan Boresch

PS: BTW, your original post (diagnosis of hardware issues) has also
convinced my vendor to do some work to honor his warranty. So, my next
job is to dig into the big box which just arrived by fed-ex containing
all possible replacements (including a new motherboard ..). Maybe,
I'll eventually get U320 running on this machine ;-)

-- 
Stefan Boresch
Institute for Computational Biological Chemistry
University of Vienna, Waehringerstr. 17       A-1090 Vienna, Austria
Phone: -43-1-427752715                        Fax:   -43-1-427752790

  reply	other threads:[~2007-09-24 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22 13:40 [PATCH] scsi_transport_spi: fix domain validation failure from incorrect width setting James Bottomley
2007-09-24 12:10 ` Stefan Boresch [this message]
2007-09-24 13:50   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070924121004.GR1606@loop.mdy.univie.ac.at \
    --to=stefan@mdy.univie.ac.at \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.