From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IZmuW-00056m-J8 for qemu-devel@nongnu.org; Mon, 24 Sep 2007 08:19:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IZmuV-00056W-2J for qemu-devel@nongnu.org; Mon, 24 Sep 2007 08:19:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZmuU-00056T-Un for qemu-devel@nongnu.org; Mon, 24 Sep 2007 08:19:34 -0400 Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IZmuU-0005wu-LZ for qemu-devel@nongnu.org; Mon, 24 Sep 2007 08:19:34 -0400 Date: Mon, 24 Sep 2007 13:19:29 +0100 From: Thiemo Seufer Subject: Re: [Qemu-devel] Updated RFC: linux user problems]] Message-ID: <20070924121929.GA27468@networkno.de> References: <1190356760.14938.409.camel@rapid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1190356760.14938.409.camel@rapid> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "J. Mayer" Cc: qemu-devel@nongnu.org J. Mayer wrote: [snip] > > > > May someone take a look at my patch and say if it seems reasonable to > > > > include this in the repository ? > > > > > > Looks reasonable, but introduces new compiler warnings > > > (on a ppc32/Linux host): > > The reported warnings have been fixed. > There are still a lot of warnings related to 32/64 bits invalid casts on > 64 bits hosts (see above) which will need to be fixed once. > > I also changed some parameters of do_ipc from long to int (instead of > target_long), following the do_ipc man page specification, and reported > this change in child functions. There may be more to do... > > Please comment... Fine with me, FWIW. Thiemo