All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: lepton <ytht.net@gmail.com>
Cc: lkm <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.22.6 user-mode linux: use address instead of value as argument in os_free_irq_by_cb
Date: Mon, 24 Sep 2007 13:02:20 -0400	[thread overview]
Message-ID: <20070924170220.GE23078@c2.user-mode-linux.org> (raw)
In-Reply-To: <20070922043955.GA4550@router.lepton.home>

On Sat, Sep 22, 2007 at 12:39:55PM +0800, lepton wrote:
>   There is a bug in os_free_irq_by_cb, when the first element
>   of active_fds list  is free, the value of active_fds is not
>   updated, just value in stack is updated.

Man, that sucks.

Nice spotting.

> 
>   The intresting thing is that without this patch, a poweroff
>   in user mode linux guest will halt the host linux system.It
>   seems that after the tracing thread is dead, the syscall to
>   sys_reboot of the traced thread is executed by host. I don't
>   know if it is another bug.

I would say that you shouldn't be running UMLs as root.  However, a
sys_reboot shouldn't escape being ptraced either.  This is a bug, but
I don't see any connection between it and ptrace missing a final
system call.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

  reply	other threads:[~2007-09-24 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22  4:39 [PATCH] 2.6.22.6 user-mode linux: use address instead of value as argument in os_free_irq_by_cb lepton
2007-09-24 17:02 ` Jeff Dike [this message]
2007-09-25  1:13   ` lepton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070924170220.GE23078@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ytht.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.