From: Christoph Hellwig <hch@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
mickflemm@gmail.com, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/2 try 2] Net: ath5k, split hw into hw, phy and initvals
Date: Mon, 24 Sep 2007 18:36:07 +0100 [thread overview]
Message-ID: <20070924173607.GA652@infradead.org> (raw)
In-Reply-To: <1190654876.18521.276.camel@johannes.berg>
On Mon, Sep 24, 2007 at 07:27:56PM +0200, Johannes Berg wrote:
> On Mon, 2007-09-24 at 13:24 -0400, Luis R. Rodriguez wrote:
>
> > * ath5k_hw_set_rfgain_opt() is defined once and used once, can we
> > instead make it inline? If we really are not going to re-use this
> > later why do we put it into a routine on its own?
>
> Why mark it inline then? The compiler will inline it anyway if it's only
> used once. And I haven't looked at the code but making it an own routine
> could possibly make the code more readable, especially if lots of
> indentation is involved.`
Seconded. Splitting things up into logically sound subroutines is
good programming style.
next prev parent reply other threads:[~2007-09-24 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 9:02 [PATCH 1/2 try 2] Net: ath5k, split hw into hw, phy and initvals Jiri Slaby
2007-09-24 9:03 ` [PATCH 2/2 try 2] Net: ath5k, use int as retval Jiri Slaby
2007-09-24 17:24 ` [PATCH 1/2 try 2] Net: ath5k, split hw into hw, phy and initvals Luis R. Rodriguez
2007-09-24 17:27 ` Johannes Berg
2007-09-24 17:36 ` Christoph Hellwig [this message]
2007-09-24 17:51 ` Luis R. Rodriguez
2007-09-24 18:40 ` Jiri Slaby
2007-09-24 18:42 ` Jiri Slaby
2007-09-24 18:51 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924173607.GA652@infradead.org \
--to=hch@infradead.org \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.