From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Mon, 24 Sep 2007 17:07:00 +0000 Subject: Re: [lm-sensors] [patch 2.6.23-rc6] lm75: new-style i2c binding, Message-Id: <20070924190700.18e232b4@hyperion.delvare> List-Id: References: <20070916234519.861D3C24EE@adsl-69-226-248-13.dsl.pltn13.pacbell.net> In-Reply-To: <20070916234519.861D3C24EE@adsl-69-226-248-13.dsl.pltn13.pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: lm-sensors@vger.kernel.org Hi David, On Sun, 16 Sep 2007 16:45:19 -0700, David Brownell wrote: > Updates and cleanups for lm75: >=20 > - Update the LM75 driver to handle new-style I2C driver binding > (following the driver model). >=20 > - Use 12 bit resolution (1/16 degree C) on chips that support it, > instead of 9 bit (1/2 degree C); needs new conversion routines. >=20 > - Grow the list of compatible chips; update Kconfig accordingly. >=20 > - On driver disconnect, restore the original device config (which > usually means shutdown). >=20 > - Some code cleanups: a handful of whitespace fixes, and clearly > marking the various driver components (sysfs/hwmon attributes, > driver core support, legacy stuff, register access, module glue). This is crying for at least two separate patches, and ideally more like 3 or 4. Additionally, I can't apply your patch to my tree. Presumably you are missing recent patches that went into Mark's hwmon-testing tree and which affect the lm75 driver: hwmon: Allow writing of negative trigger temperatures http://lm-sensors.org/kernel?p=3Dkernel/mhoffman/hwmon-2.6.git;a=3Dcommit;h= =A1efde3fd7b3d94c942b1a675da992c8a2f1f04b hwmon: Convert from class_device to device http://lm-sensors.org/kernel?p=3Dkernel/mhoffman/hwmon-2.6.git;a=3Dcommit;h= =F89523a27def89ddc74d094a0910970f6a1c6f43 If you split your patch and make sure that the result applies on top of the above patches, I'll be happy to review and test your work. > The way to kick in higher sample resolution on a given board is to > use the new style binding to pass in the chip type. >=20 > One temporary omission: IRQ support, or for the TI chips SMBALERT# > notifications. --=20 Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors