From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Wu <flamingice@sourmilk.net>,
Ulrich Kunitz <kune@deine-taler.de>,
Daniel Drake <dsd@gentoo.org>,
linux-wireless@vger.kernel.org,
John Linville <linville@tuxdriver.com>
Subject: Re: zd1211 config operation problem
Date: Mon, 24 Sep 2007 21:58:37 +0200 [thread overview]
Message-ID: <200709242158.37848.mb@bu3sch.de> (raw)
In-Reply-To: <1190654481.18521.274.camel@johannes.berg>
On Monday 24 September 2007, Johannes Berg wrote:
> On Mon, 2007-09-24 at 19:20 +0200, Johannes Berg wrote:
> > On Mon, 2007-09-24 at 18:41 +0200, Michael Buesch wrote:
> >
> > > - if (local->ops->config)
> > > + if (local->open_count)
> > > ret = local->ops->config(local_to_hw(local), &local->hw.conf);
> >
> > Isn't this racy?
>
> Also, shouldn't we then call ->config when the first interface is
> brought up or something?
I don't know. You are the one who knows the code. ;)
I'm just pointing at problems that I'm not able to fix,
because I don't know the code.
next prev parent reply other threads:[~2007-09-24 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 14:48 zd1211 config operation problem Michael Buesch
2007-09-23 15:47 ` Ulrich Kunitz
2007-09-23 17:48 ` Michael Wu
2007-09-24 16:41 ` Michael Buesch
2007-09-24 17:20 ` Johannes Berg
2007-09-24 17:21 ` Johannes Berg
2007-09-24 19:22 ` Michael Wu
2007-09-24 19:29 ` Johannes Berg
2007-09-24 19:58 ` Michael Buesch [this message]
2007-09-24 19:20 ` Michael Wu
2007-09-24 19:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709242158.37848.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dsd@gentoo.org \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.