From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [patch 2.6.23-rc6] lm75: new-style i2c binding,
Date: Tue, 25 Sep 2007 09:24:53 +0000 [thread overview]
Message-ID: <20070925112453.0eb2d87f@hyperion.delvare> (raw)
In-Reply-To: <20070916234519.861D3C24EE@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
On Mon, 24 Sep 2007 13:18:39 -0700, David Brownell wrote:
> > This is crying for at least two separate patches, and ideally more like
> > 3 or 4.
>
> I was fairly sure someone was going to say that. I take it that
> there's no real technical comment on the changes though?
No. Take it that I did not review the patch, so I have no clue if it is
good or not. The whole point of asking for split patches is to make the
review easier so that it actually happens.
> > Additionally, I can't apply your patch to my tree. Presumably you are
> > missing recent patches that went into Mark's hwmon-testing tree and
> > which affect the lm75 driver:
>
> The location of that tree seems to be hidden. I did find a GIT
> tree of Mark's, but it didn't have any lm75 changes.
MAINTAINERS says:
T: git lm-sensors.org:/kernel/mhoffman/hwmon-2.6.git
It indeed doesn't mention the testing branch, while this is the
interesting one. Mark, is there something that can be done to improve
the situation?
> > If you split your patch and make sure that the result applies on top of
> > the above patches, I'll be happy to review and test your work.
>
> I'll split it out a bit then.
Great, thanks.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-09-25 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 23:45 [lm-sensors] [patch 2.6.23-rc6] lm75: new-style i2c binding, cleanup David Brownell
2007-09-24 17:07 ` [lm-sensors] [patch 2.6.23-rc6] lm75: new-style i2c binding, Jean Delvare
2007-09-24 20:18 ` David Brownell
2007-09-25 5:12 ` David Brownell
2007-09-25 9:24 ` Jean Delvare [this message]
2007-10-07 18:57 ` Mark M. Hoffman
2007-10-07 20:45 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925112453.0eb2d87f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.