From: Matt Kraai <kraai@ftbfs.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Move convert-objects to contrib.
Date: Tue, 25 Sep 2007 07:04:25 -0700 [thread overview]
Message-ID: <20070925140425.GA6061@ftbfs.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0709251100560.28395@racer.site>
On Tue, Sep 25, 2007 at 11:01:58AM +0100, Johannes Schindelin wrote:
> the commit message looks a little bit empty to me. I'd at least mention
> why convert-objects was needed, why it is no longer needed, and that
> Linus, the original author, is okay with it.
>
> And you might want to use the "-M" flag to format-patch next time (detect
> renames).
OK, thanks. I've resubmitted the patch, (hopefully) taking both
suggestions into account.
--
Matt
next prev parent reply other threads:[~2007-09-25 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 3:14 [PATCH] Move convert-objects to contrib Matt Kraai
2007-09-25 10:01 ` Johannes Schindelin
2007-09-25 14:04 ` Matt Kraai [this message]
2007-09-25 14:06 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 14:03 Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925140425.GA6061@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.