From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 3/8]: Remove duplicate code for Reset from connected
Date: Tue, 25 Sep 2007 14:51:27 +0000 [thread overview]
Message-ID: <20070925145127.GG18348@ghostprotocols.net> (raw)
In-Reply-To: <200709251530.21163@strip-the-willow>
Em Tue, Sep 25, 2007 at 03:30:21PM +0100, Gerrit Renker escreveu:
> [DCCP]: Remove duplicate code for Reset from connected socket
>
> In this patch, duplicated code is removed for the case when a Reset packet is
> sent from a connected socket. This code duplication is between dccp_make_reset
> and dccp_transmit_skb, which already contained an (up to now entirely unused)
> switch statement to fill in the reset code from the DCCP_SKB_CB.
>
> The only thing that has been removed is the call to dst_clone(dst), since
> the queue_xmit functions use sk_dst_cache anyway.
>
> I wasn't sure which purpose inet_sk_rebuild_header served, so I left it in.
I'll check this later, to finally remove that comment in dccp_send_reset
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Looks ok, applying.
- Arnaldo
next prev parent reply other threads:[~2007-09-25 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 14:30 [PATCH 3/8]: Remove duplicate code for Reset from connected socket Gerrit Renker
2007-09-25 14:51 ` Arnaldo Carvalho de Melo [this message]
2007-09-25 22:53 ` Ian McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925145127.GG18348@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.