From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IaIP3-0004xx-31 for user-mode-linux-devel@lists.sourceforge.net; Tue, 25 Sep 2007 14:57:13 -0700 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IaIP2-0003wU-Je for user-mode-linux-devel@lists.sourceforge.net; Tue, 25 Sep 2007 14:57:13 -0700 Date: Tue, 25 Sep 2007 17:56:29 -0400 From: Jeff Dike Message-ID: <20070925215629.GA10926@c2.user-mode-linux.org> References: <20070925173713.GA8262@c2.user-mode-linux.org> <1190750055.17409.38.camel@chaos> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <1190750055.17409.38.camel@chaos> Subject: Re: [uml-devel] [PATCH] UML - time build fix List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Thomas Gleixner Cc: Andrew Morton , LKML , uml-devel On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > Put back an implementation of timeval_to_ns in > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > > support that there was a perfectly good implementation of it in > > linux/time.h. The problem is that this is userspace code which can't > > pull in kernel headers and there doesn't seem to be a libc version. > > Oops. Did not notice. It's a UML peculiarity... > Can't we move it into some header file which is accessible from everywhere ? Not in the generic kernel. UML has some generally includable headers of its own, but that doesn't really help. The one thing that would help is a libc timeval_to_ns. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbXIYV53 (ORCPT ); Tue, 25 Sep 2007 17:57:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750909AbXIYV5W (ORCPT ); Tue, 25 Sep 2007 17:57:22 -0400 Received: from [198.99.130.12] ([198.99.130.12]:55134 "EHLO saraswathi.solana.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751190AbXIYV5W (ORCPT ); Tue, 25 Sep 2007 17:57:22 -0400 Date: Tue, 25 Sep 2007 17:56:29 -0400 From: Jeff Dike To: Thomas Gleixner Cc: Andrew Morton , LKML , uml-devel Subject: Re: [PATCH] UML - time build fix Message-ID: <20070925215629.GA10926@c2.user-mode-linux.org> References: <20070925173713.GA8262@c2.user-mode-linux.org> <1190750055.17409.38.camel@chaos> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1190750055.17409.38.camel@chaos> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote: > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote: > > Put back an implementation of timeval_to_ns in > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless > > support that there was a perfectly good implementation of it in > > linux/time.h. The problem is that this is userspace code which can't > > pull in kernel headers and there doesn't seem to be a libc version. > > Oops. Did not notice. It's a UML peculiarity... > Can't we move it into some header file which is accessible from everywhere ? Not in the generic kernel. UML has some generally includable headers of its own, but that doesn't really help. The one thing that would help is a libc timeval_to_ns. Jeff -- Work email - jdike at linux dot intel dot com