From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ns.suse.de ([195.135.220.2] helo=mx1.suse.de) by canuck.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux)) id 1IaS3a-0001qy-KC for kexec@lists.infradead.org; Wed, 26 Sep 2007 04:15:58 -0400 Date: Wed, 26 Sep 2007 10:15:34 +0200 From: Bernhard Walle Subject: Re: [patch 5/7] Use extended crashkernel command line on ppc64 Message-ID: <20070926081534.GD11385@suse.de> References: <20070925182257.900701776@strauss.suse.de> <20070925182259.398924232@strauss.suse.de> <20070925124534.b9da41a2.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20070925124534.b9da41a2.akpm@linux-foundation.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org+dwmw2=infradead.org@lists.infradead.org To: Andrew Morton Cc: linux-arch@vger.kernel.org, linuxppc-dev@ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Hi, * Andrew Morton [2007-09-25 21:45]: > On Tue, 25 Sep 2007 20:23:02 +0200 Bernhard Walle wrote: > = > > This patch adapts the ppc64 code to use the generic parse_crashkernel() > > function introduced in the generic patch of that series. > = > I really don't like to see patches get a wholesale replacement, especially > when they've been looked at by a few people and have had some testing, et= c. > It's not possible to see what changed and people need to re-review stuff > they've already reviewed, etc. Sorry, I didn't know that this is the preferred way. I just thought it's more clear if the patches are replaced if the patch set is finally pushed into Linus' tree. > diff -puN arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-co= mmand-line-on-ppc64-update arch/powerpc/kernel/machine_kexec.c > --- a/arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-comman= d-line-on-ppc64-update > +++ a/arch/powerpc/kernel/machine_kexec.c > @@ -63,7 +63,7 @@ NORET_TYPE void machine_kexec(struct kim > = > void __init reserve_crashkernel(void) > { > - unsigned long long crash_size =3D 0, crash_base; > + unsigned long long crash_size, crash_base; > int ret; > = > /* this is necessary because of lmb_phys_mem_size() */ > _ > = > = > which I suspect will now create a compiler warning. No, it doesn't. I just verified this. CHK include/linux/compile.h CC arch/powerpc/kernel/machine_kexec.o LD arch/powerpc/kernel/built-in.o Thanks, Bernhard -- = Bernhard Walle , Architecture Maintenance SUSE LINUX Products GmbH, N=FCrnberg, Germany GF: Markus Rex, HRB 16746 (AG N=FCrnberg) OpenPGP: F61F 34CC 09CA FB82 C9F6 BA4B 8865 3696 DDAF 6454 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ns1.suse.de ([195.135.220.2]:58343 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1749667AbXIZIPg (ORCPT ); Wed, 26 Sep 2007 04:15:36 -0400 Date: Wed, 26 Sep 2007 10:15:34 +0200 From: Bernhard Walle Subject: Re: [patch 5/7] Use extended crashkernel command line on ppc64 Message-ID: <20070926081534.GD11385@suse.de> References: <20070925182257.900701776@strauss.suse.de> <20070925182259.398924232@strauss.suse.de> <20070925124534.b9da41a2.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20070925124534.b9da41a2.akpm@linux-foundation.org> Sender: linux-arch-owner@vger.kernel.org To: Andrew Morton Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@ozlabs.org List-ID: Hi, * Andrew Morton [2007-09-25 21:45]: > On Tue, 25 Sep 2007 20:23:02 +0200 Bernhard Walle wrote: > > > This patch adapts the ppc64 code to use the generic parse_crashkernel() > > function introduced in the generic patch of that series. > > I really don't like to see patches get a wholesale replacement, especially > when they've been looked at by a few people and have had some testing, etc. > It's not possible to see what changed and people need to re-review stuff > they've already reviewed, etc. Sorry, I didn't know that this is the preferred way. I just thought it's more clear if the patches are replaced if the patch set is finally pushed into Linus' tree. > diff -puN arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update arch/powerpc/kernel/machine_kexec.c > --- a/arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update > +++ a/arch/powerpc/kernel/machine_kexec.c > @@ -63,7 +63,7 @@ NORET_TYPE void machine_kexec(struct kim > > void __init reserve_crashkernel(void) > { > - unsigned long long crash_size = 0, crash_base; > + unsigned long long crash_size, crash_base; > int ret; > > /* this is necessary because of lmb_phys_mem_size() */ > _ > > > which I suspect will now create a compiler warning. No, it doesn't. I just verified this. CHK include/linux/compile.h CC arch/powerpc/kernel/machine_kexec.o LD arch/powerpc/kernel/built-in.o Thanks, Bernhard -- Bernhard Walle , Architecture Maintenance SUSE LINUX Products GmbH, Nürnberg, Germany GF: Markus Rex, HRB 16746 (AG Nürnberg) OpenPGP: F61F 34CC 09CA FB82 C9F6 BA4B 8865 3696 DDAF 6454 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 21911DDDFF for ; Wed, 26 Sep 2007 18:15:40 +1000 (EST) Date: Wed, 26 Sep 2007 10:15:34 +0200 From: Bernhard Walle To: Andrew Morton Subject: Re: [patch 5/7] Use extended crashkernel command line on ppc64 Message-ID: <20070926081534.GD11385@suse.de> References: <20070925182257.900701776@strauss.suse.de> <20070925182259.398924232@strauss.suse.de> <20070925124534.b9da41a2.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20070925124534.b9da41a2.akpm@linux-foundation.org> Cc: linux-arch@vger.kernel.org, linuxppc-dev@ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, * Andrew Morton [2007-09-25 21:45]: > On Tue, 25 Sep 2007 20:23:02 +0200 Bernhard Walle wrote: > > > This patch adapts the ppc64 code to use the generic parse_crashkernel() > > function introduced in the generic patch of that series. > > I really don't like to see patches get a wholesale replacement, especially > when they've been looked at by a few people and have had some testing, etc. > It's not possible to see what changed and people need to re-review stuff > they've already reviewed, etc. Sorry, I didn't know that this is the preferred way. I just thought it's more clear if the patches are replaced if the patch set is finally pushed into Linus' tree. > diff -puN arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update arch/powerpc/kernel/machine_kexec.c > --- a/arch/powerpc/kernel/machine_kexec.c~use-extended-crashkernel-command-line-on-ppc64-update > +++ a/arch/powerpc/kernel/machine_kexec.c > @@ -63,7 +63,7 @@ NORET_TYPE void machine_kexec(struct kim > > void __init reserve_crashkernel(void) > { > - unsigned long long crash_size = 0, crash_base; > + unsigned long long crash_size, crash_base; > int ret; > > /* this is necessary because of lmb_phys_mem_size() */ > _ > > > which I suspect will now create a compiler warning. No, it doesn't. I just verified this. CHK include/linux/compile.h CC arch/powerpc/kernel/machine_kexec.o LD arch/powerpc/kernel/built-in.o Thanks, Bernhard -- Bernhard Walle , Architecture Maintenance SUSE LINUX Products GmbH, Nürnberg, Germany GF: Markus Rex, HRB 16746 (AG Nürnberg) OpenPGP: F61F 34CC 09CA FB82 C9F6 BA4B 8865 3696 DDAF 6454