From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 1/8]: Add FIXME for send_delayed_ack
Date: Wed, 26 Sep 2007 08:44:00 +0000 [thread overview]
Message-ID: <200709260944.00380@strip-the-willow> (raw)
In-Reply-To: <200709251529.52965@strip-the-willow>
Ian -
| How about using #if 0, #endif around it to keep the code in the tree
| but not compiled.
|
| This is done a fair bit elsewhere and if never used it gets removed.
this is a good idea actually, the problem that I have with this is it makes the
code look unfinished and hackish, but this is a self-contained function which I
think would serve its purpose - it is just not used at the moment.
I was considering taking this on board, but noted that Arnaldo had applied this
already. And I think that keeping delayed Acks an option might be useful for CCID2.
prev parent reply other threads:[~2007-09-26 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 14:29 [PATCH 1/8]: Add FIXME for send_delayed_ack Gerrit Renker
2007-09-25 14:40 ` Arnaldo Carvalho de Melo
2007-09-25 19:27 ` Ian McDonald
2007-09-26 8:44 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709260944.00380@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.