All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139)
Date: Wed, 26 Sep 2007 16:55:31 +0100	[thread overview]
Message-ID: <20070926155531.GB29729@redhat.com> (raw)
In-Reply-To: <46FA7F08.4070109-6ktuUTfB/bM@public.gmane.org>

On Wed, Sep 26, 2007 at 05:47:20PM +0200, Laurent Vivier wrote:
> Hi,
> 
> I think there is a bug in qemu RTL8139.
> 
> RTL8139 uses:
> 
> cpu_register_physical_memory(addr + 0, 0x100, s->rtl8139_mmio_io_addr);
> 
> But in the comment of cpu_register_physical_memory() we have:
> 
> "'size' must be a multiple of the target page size."
> 
> And I think 0x100 is not a multiple of target page size.... :-P

Latest upstream QEMU has fixed its memory handling so that MMIO regions
do not need to be a multiple of page size. Changing RTL8139 to use a
block of size 0x1000 is a reasonable short term hack around the problem,
but syncing with latest QEMU is the real solution, since there are other
places in the code which will have similar issues.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2007-09-26 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 18:59 [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139) SourceForge.net
     [not found] ` <E1IaFcv-0003fu-Oi-fsxqSYOXIJgGKePtCzJsP6QD96bmaF075NbjCUgZEJk@public.gmane.org>
2007-09-26 15:47   ` Laurent Vivier
     [not found]     ` <46FA7F08.4070109-6ktuUTfB/bM@public.gmane.org>
2007-09-26 15:55       ` Daniel P. Berrange [this message]
2007-09-26 16:02         ` [kvm-devel] " Laurent Vivier
     [not found]           ` <46FA828D.1080303-6ktuUTfB/bM@public.gmane.org>
2007-09-26 16:11             ` Daniel P. Berrange
     [not found]               ` <20070926161131.GC29729-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-09-27  9:41                 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070926155531.GB29729@redhat.com \
    --to=berrange-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Laurent.Vivier-6ktuUTfB/bM@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.