All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Michael Wu <flamingice@sourmilk.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: fix interface initialisation and deinitialisation
Date: Wed, 26 Sep 2007 16:37:56 +0200	[thread overview]
Message-ID: <200709261637.56556.mb@bu3sch.de> (raw)
In-Reply-To: <1190809643.4204.3.camel@johannes.berg>

On Wednesday 26 September 2007 14:27:23 Johannes Berg wrote:
> When an interface is registered it is still uninitialised so
> ieee80211_if_reinit() can't be called on it (it will oops.)
> Hence, we need to move the uninit method assignment.
> 
> Also, this patch fixes the bug that the master device is never
> initialised nor deinitialised at all. Oddly, the deinit code
> had an if statement to not run some code when running for the
> master interface (which never happened), but that if statement
> is also wrong. Fix that too.
> 
> Now that the uninit code is run for the master device, another
> bug surfaced: it tries to remove all dependent interfaces and
> that oopses or BUGs at some point, either because it unregisters
> already unregistered interfaces (missing list_del bug) or due
> to trying to iterate a list that has had other things removed.
> Fix this too by handling the master interface specially.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

This works fine without any crashes or problems here.

-- 
Greetings Michael.

      reply	other threads:[~2007-09-26 14:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 20:06 mac80211: crash while adding interface Michael Buesch
2007-09-25 20:36 ` Johannes Berg
2007-09-25 20:45   ` Johannes Berg
2007-09-25 21:31 ` [PATCH] mac80211: fix interface initialisation Johannes Berg
2007-09-25 21:32   ` Michael Buesch
2007-09-25 21:44     ` Johannes Berg
2007-09-26  0:02   ` Luis R. Rodriguez
2007-09-26  7:04     ` Johannes Berg
2007-09-26 12:27   ` [PATCH v2] mac80211: fix interface initialisation and deinitialisation Johannes Berg
2007-09-26 14:37     ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709261637.56556.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.