From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: thomas@m3y3r.de, linux-kernel@vger.kernel.org
Subject: Re: xpad_probe: undefined reference to `led_classdev_register'
Date: Wed, 26 Sep 2007 18:33:22 -0400 [thread overview]
Message-ID: <200709261833.22226.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20070926145531.d1e0819c.randy.dunlap@oracle.com>
Hi,
On Wednesday 26 September 2007, Randy Dunlap wrote:
> On Wed, 26 Sep 2007 23:25:33 +0200 thomas@m3y3r.de wrote:
>
> > Hi.
> >
> > Current linus' git tree:
> >
> > x86_64-unknown-linux-gnu-ld: BFD 2.15 assertion fail
> > /home/thomas/source/crosstool-0.43/build/x86_64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/binutils-2.15/bfd/linker.c:619
> > drivers/built-in.o(.text+0x20749d): In function `xpad_probe':
> > : undefined reference to `led_classdev_register'
> > drivers/built-in.o(.text+0x20756c): In function `xpad_disconnect':
> > : undefined reference to `led_classdev_unregister'
> > make: *** [.tmp_vmlinux1] Fehler 1
> >
> > any ideas?
>
> Please send .config file.
>
> Ix xpad driver built-in (yes, it is) and led driver is modular?
> We can fix that...
>
I have the patch below in mytree. I guess I need to forward it to Linus
insterad of waiting for 2.6.24 as too many people hit this.
--
Dmitry
Input: xpad - fix dependancy on LEDS class
The driver can not be built-in when LEDS class is a module.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/joystick/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: work/drivers/input/joystick/Kconfig
===================================================================
--- work.orig/drivers/input/joystick/Kconfig
+++ work/drivers/input/joystick/Kconfig
@@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
config JOYSTICK_XPAD_LEDS
bool "LED Support for Xbox360 controller 'BigX' LED"
- depends on LEDS_CLASS && JOYSTICK_XPAD
+ depends on JOYSTICK_XPAD && (LEDS_CLASS=y || LEDS_CLASS=JOYSTICK_XPAD)
---help---
This option enables support for the LED which surrounds the Big X on
XBox 360 controller.
next prev parent reply other threads:[~2007-09-26 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 21:25 xpad_probe: undefined reference to `led_classdev_register' thomas
2007-09-26 21:55 ` Randy Dunlap
2007-09-26 22:33 ` Dmitry Torokhov [this message]
2007-09-26 22:35 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709261833.22226.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.