All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: util-linux-ng-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH, RFC] add fsck to util-linux
Date: Wed, 26 Sep 2007 20:16:27 -0400	[thread overview]
Message-ID: <20070927001627.GA18346@thunk.org> (raw)
In-Reply-To: <20070926120533.GA15894-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Wed, Sep 26, 2007 at 01:05:33PM +0100, Christoph Hellwig wrote:
>  - make mount/fsck use libvolume_id unconditionally for detecting the
>    filesystem type.  There's absolute no reason to use anything in
>    libblkid for this, and caching the result doesn't help us at all
>    as we're going to touch the disk anyway as part of the mount/fsck.
>  - make libblkid use libvolume_id internally for filesystem detection

No, that's not true, since on a non-udev system (and there are those,
including a number of kernel hackers, who don't use udev for a number
of reasons --- like not trusting the sysfs/udev breakages, and who
want a static /dev) you need an efficient way to do lookup by UUID or
by LABEL without needing to search every single device.  If you have a
some large storage box with 30,000 LUN's, you don't want to search
them all at boot time, whether you are using udev, especially if you
are only mounting a small subset of the images on demand.  So there
will be circumstances where you really will want to use the cache, and
*not* want to use /dev/disk/by-* as the lookup mechanism.

      	      	  		    	       - Ted

  parent reply	other threads:[~2007-09-27  0:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 11:38 [PATCH 0/3] Move fsck from e2fsprogs to util-linux-ng Matthias Koenig
2007-09-25 15:37 ` [PATCH, RFC] add fsck to util-linux Christoph Hellwig
2007-09-26 10:59   ` Theodore Tso
2007-09-26 12:05     ` Christoph Hellwig
     [not found]       ` <20070926120533.GA15894-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2007-09-26 19:07         ` Karel Zak
2007-09-26 22:54         ` Andreas Dilger
2007-09-27  0:16         ` Theodore Tso [this message]
     [not found]     ` <20070926105946.GB429-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2007-09-26 12:29       ` Kay Sievers
2008-02-06 11:39 ` [PATCH 1/3] fsck: add fsck from e2fsprogs to util-linux-ng tree Matthias Koenig
     [not found] ` <20080206113426.7833.59505.stgit-qv7XSOoqp4Ab1SvskN2V4Q@public.gmane.org>
2008-02-06 11:39   ` [PATCH 2/3] fsck: add support for the fsprobe library wrapper Matthias Koenig
     [not found]     ` <20080206113902.7833.57924.stgit-qv7XSOoqp4Ab1SvskN2V4Q@public.gmane.org>
2008-02-07 13:49       ` Theodore Tso
2008-02-06 11:39   ` [PATCH 3/3] fsck: Do not check mounted filesystems Matthias Koenig
     [not found]   ` <20070925153735.GA26693-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-02-18 16:42     ` [PATCH, RFC] add fsck to util-linux Karel Zak
2009-02-19 18:42       ` Christoph Hellwig
2008-02-06 12:56 ` [PATCH 0/3] Move fsck from e2fsprogs to util-linux-ng Karel Zak
2008-02-06 14:05   ` Theodore Tso
     [not found]     ` <20080206140559.GJ27119-3s7WtUTddSA@public.gmane.org>
2008-02-06 15:23       ` Karel Zak
2008-02-06 16:26         ` maximilian attems
2008-02-07  0:37       ` Kay Sievers
2008-02-07 13:41         ` Theodore Tso
2008-02-08 11:16           ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070927001627.GA18346@thunk.org \
    --to=tytso-3s7wtutddsa@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=util-linux-ng-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.