All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] 85xx io out functions need sync after write.
Date: Thu, 27 Sep 2007 07:31:00 +0200	[thread overview]
Message-ID: <200709270731.01164.sr@denx.de> (raw)
In-Reply-To: <11908425541324-git-send-email-Ed.Swarthout@freescale.com>

On Wednesday 26 September 2007, Ed Swarthout wrote:
> This fixes the mc146818 rtc_read/write functions for 85xx.
>
> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
> ---
>
>  cpu/mpc85xx/start.S |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/cpu/mpc85xx/start.S b/cpu/mpc85xx/start.S
> index 2c98c2a..5d65190 100644
> --- a/cpu/mpc85xx/start.S
> +++ b/cpu/mpc85xx/start.S
> @@ -701,6 +701,7 @@ in8:
>  	.globl	out8
>  out8:
>  	stb	r4,0x0000(r3)
> +	sync

Another way would be to use the out_be32() and friends functions defined in 
asm-ppc/io.h. They already have the sync/barrier included and are recommened 
for accessing peripheral devices.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2007-09-27  5:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 21:35 [U-Boot-Users] [PATCH] 85xx io out functions need sync after write Ed Swarthout
2007-09-26 21:50 ` Andy Fleming
2007-09-27  5:31 ` Stefan Roese [this message]
2007-09-27  6:25   ` Swarthout Edward L-SWARTHOU
2007-09-27  8:41     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709270731.01164.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.