From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IawWL-00063x-FK
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:47:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IawWJ-00062W-OZ
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:47:24 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IawWJ-00062N-Eq
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:47:23 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1IawWJ-0005as-31
	for qemu-devel@nongnu.org; Thu, 27 Sep 2007 12:47:23 -0400
Date: Thu, 27 Sep 2007 17:47:19 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu...
Message-ID: <20070927164719.GC13317@networkno.de>
References: <E1IatsM-0004DD-6T@cvs.savannah.gnu.org>
	<1190902080.29748.2.camel@jma4.dev.netgem.com>
	<1190908428.27143.7.camel@phantasm.home.enterpriseandprosperity.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1190908428.27143.7.camel@phantasm.home.enterpriseandprosperity.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thayne Harbaugh <thayne@c2.net>
Cc: qemu-devel@nongnu.org

Thayne Harbaugh wrote:
[snip]
> >  static inline target_ulong get_sp_from_cpustate(CPUPPCState *state)
> > {
> >   return state->gpr[1];
> > }
> > 
> > This is no way related to CPU emulation then has nothing to do in cpu.h.
> > Furthermore, there no notion of sigaltstack or even stack pointer in the
> > PowerPC specification.
> > Revert this patch immediatly, please, and stop breaking others code...
> 
> My apologies.  I put get_sp_from_cpustate() in cpu.h because it is a
> generic function that isn't exclusive to sigaltstack().  If it's
> preferred it can be exclusive to sigaltstack().

I moved it over to target_signal.h, which seems to be the best place
for the time being. I also enabled do_sigaltstack processing for
MIPS, PPC and Alpha, as I don't see a reason not to support it.


Thiemo