From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: neilb@suse.de, nfs@lists.sourceforge.net, gnb@sgi.com
Subject: Re: [RFC,PATCH 00/33] SVC Transport Switch
Date: Thu, 27 Sep 2007 13:55:38 -0400 [thread overview]
Message-ID: <20070927175538.GC10113@fieldses.org> (raw)
In-Reply-To: <20070927045751.12677.98896.stgit@dell3.ogc.int>
On Wed, Sep 26, 2007 at 11:57:51PM -0500, Tom Tucker wrote:
> The following series implements a pluggable transport switch for
> RPC servers.
Seeing as this seems not to break anything obvious (well, it compiles
anyway), and people seem to agree we'll merge some version of this
eventually, I've added it to for-mm in hopes it'll get included in an
-mm release soon.
I'll take an hour to read through it some time just for fun, but I'm
depending on Neil and others for serious review in this case. (One
trivial complaint: git's complaining about lines that add trailing
whitespace. Might want to run scripts/checkpatch.pl, feeling free to
ignore any false positives.)
--b.
> The biggest changes in this latest incarnation
> are as follows:
>
> - The overall design of the switch has been modified to be more similar
> to the client side, e.g.
> - There is a transport class structure svc_xprt_class, and
> - A transport independent structure is manipulated by xprt
> independent code (svc_xprt)
> - Further consolidation of transport independent logic out of
> transport providers and into transport independent code.
> - Transport independent code has been broken out into a separate file
> - Transport independent functions prevously adorned with _sock_ have
> had their names changed, e.g. svc_sock_enqueue
> - atomic refcounts have been changed to krefs
>
> The patchset is large (33 patches). There are some things that I would like to
> do that I didn't do because the patchset is already big. For example, normalize
> the creation of nfsd listening endpoints using writes to the portlist file.
>
> I've attempted to organize the patchset such that logical changes are
> clearly reviewable without too much clutter from functionally empty name
> changes. This was somewhat awkward since intermediate patches may look
> ugly/broken/incomplete to some reviewers. This was to avoid losing the
> context of a change while keeping each patch a reasonable size. For example,
> making svc_recv transport independent and moving it to the svc_xprt file
> cannot be done in the same patch without losing the diffs to the svc_recv
> function.
>
> This patchset has had limited testing with TCP/UDP. In this case, the tests
> included connectathon and building the kernel on an NFS mount running on the
> transport switch.
>
> This patchset is against the 2.6.23-rc8 kernel tree.
>
> --
> Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> NFS maillist - NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-09-27 17:55 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 4:57 [RFC,PATCH 00/33] SVC Transport Switch Tom Tucker
2007-09-27 5:01 ` [RFC,PATCH 01/33] svc: Add an svc transport class Tom Tucker
2007-09-27 5:01 ` [RFC,PATCH 02/33] svc: Make svc_sock the tcp/udp transport Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 03/33] svc: Change the svc_sock in the rqstp structure to a transport Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 04/33] svc: Add a max payload value to the transport Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 05/33] svc: Move sk_sendto and sk_recvfrom to svc_xprt_class Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 06/33] svc: Add transport specific xpo_release function Tom Tucker
2007-09-28 2:58 ` Neil Brown
2007-09-28 16:06 ` Tom Tucker
2007-09-27 5:01 ` [RFC,PATCH 07/33] svc: Add per-transport delete functions Tom Tucker
2007-09-27 5:01 ` [RFC,PATCH 08/33] svc: Add xpo_prep_reply_hdr Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 09/33] svc: Add a transport function that checks for write space Tom Tucker
2007-09-28 3:03 ` Neil Brown
2007-09-28 16:09 ` Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 10/33] svc: Move close processing to a single place Tom Tucker
2007-09-27 5:01 ` [RFC,PATCH 11/33] svc: Add xpo_accept transport function Tom Tucker
2007-09-28 3:21 ` Neil Brown
2007-09-28 16:10 ` Tom Tucker
2007-09-27 5:01 ` [RFC, PATCH 12/33] svc: Add a generic transport svc_create_xprt function Tom Tucker
2007-09-28 3:21 ` Neil Brown
2007-09-28 16:15 ` Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 13/33] svc: Change services to use new svc_create_xprt service Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 14/33] svc: Change sk_inuse to a kref Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 15/33] svc: Move sk_flags to the svc_xprt structure Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 16/33] svc: Move sk_server and sk_pool to svc_xprt Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 17/33] svc: Make close transport independent Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 18/33] svc: Move sk_reserved to svc_xprt Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 19/33] svc: Make the enqueue service transport neutral and export it Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 20/33] svc: Make svc_send transport neutral Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 21/33] svc: Change svc_sock_received to svc_xprt_received and export it Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 22/33] svc: Move sk_lastrecv to svc_xprt Tom Tucker
2007-09-28 4:25 ` Neil Brown
2007-09-28 16:16 ` Tom Tucker
2007-10-03 10:10 ` Greg Banks
2007-09-27 5:02 ` [RFC,PATCH 23/33] svc: Move the authinfo cache " Tom Tucker
2007-09-28 4:30 ` [RFC, PATCH " Neil Brown
2007-09-29 20:49 ` Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 24/33] svc: Make deferral processing xprt independent Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 25/33] svc: Move the sockaddr information to svc_xprt Tom Tucker
2007-09-28 4:36 ` Neil Brown
2007-09-28 16:44 ` Tom Tucker
2007-09-28 16:53 ` Chuck Lever
2007-09-27 5:02 ` [RFC, PATCH 26/33] svc: Make svc_sock_release svc_xprt_release Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 27/33] svc: Make svc_recv transport neutral Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 28/33] svc: Make svc_age_temp_sockets svc_age_temp_transports Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 29/33] svc: Move common create logic to common code Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 30/33] svc: Removing remaining references to rq_sock in rqstp Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 31/33] svc: Move the xprt independent code to the svc_xprt.c file Tom Tucker
2007-09-27 5:02 ` [RFC,PATCH 32/33] svc: Add /proc/sys/sunrpc/transport files Tom Tucker
2007-09-27 5:02 ` [RFC, PATCH 33/33] knfsd: Support adding transports by writing portlist file Tom Tucker
2007-09-28 4:48 ` Neil Brown
2007-09-28 17:33 ` Tom Tucker
2007-10-03 10:27 ` Greg Banks
2007-09-27 17:55 ` J. Bruce Fields [this message]
2007-09-28 4:51 ` [RFC,PATCH 00/33] SVC Transport Switch Neil Brown
2007-09-28 17:39 ` Tom Tucker
2007-10-01 15:58 ` J. Bruce Fields
2007-10-03 9:57 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927175538.GC10113@fieldses.org \
--to=bfields@fieldses.org \
--cc=gnb@sgi.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.