From: Jens Axboe <jens.axboe@oracle.com>
To: Theodore Tso <tytso@mit.edu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arjan van de Ven <arjan@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Correct SuS compliance for open of large file without options
Date: Fri, 28 Sep 2007 01:41:59 +0200 [thread overview]
Message-ID: <20070927234158.GB10154@kernel.dk> (raw)
In-Reply-To: <20070927155902.GA6450@thunk.org>
On Thu, Sep 27 2007, Theodore Tso wrote:
> On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote:
> > > Well it's not my call, just seems like a really bad idea to change the
> > > error value. You can't claim full coverage for such testing anyway, it's
> > > one of those things that people will complain about two releases later
> > > saying it broke app foo.
> >
> > Strange since we've spent years changing error values and getting them
> > right in the past.
>
> I doubt there any apps which are going to specifically check for EFBIG
> and do soemthing different if they get EOVERFLOW instead. If it was
> something like EAGAIN or EPERM, I'd be more concerned, but EFBIG
> vs. EOVERFLOW? C'mon!
It's not checking EFBIG vs EOVERFLOW, it's checking one and not the
other. But I digress, not trying to NAK the patch, just voicing my
opinion on the matter. It's not something you can easily test and claim
good app coverage, though.
--
Jens Axboe
prev parent reply other threads:[~2007-09-27 23:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 13:29 [PATCH] fs: Correct SuS compliance for open of large file without options Alan Cox
2007-09-27 14:01 ` Arjan van de Ven
2007-09-27 14:19 ` Alan Cox
2007-09-27 14:35 ` Jens Axboe
2007-09-27 14:44 ` Alan Cox
2007-09-27 15:08 ` Jens Axboe
2007-09-27 15:19 ` Alan Cox
2007-09-27 15:19 ` Alan Cox
2007-09-27 15:59 ` Theodore Tso
2007-09-27 17:23 ` Andrew Morton
2007-09-27 17:59 ` Greg KH
2007-09-27 18:37 ` Theodore Tso
2007-09-27 18:45 ` Matthew Wilcox
2007-09-27 18:45 ` Matthew Wilcox
2007-09-27 21:34 ` Greg KH
2007-09-27 21:34 ` Greg KH
2007-09-27 22:27 ` Kyle Moffett
2007-09-27 23:11 ` Greg KH
2007-09-27 23:19 ` Theodore Tso
2007-09-27 23:28 ` Matthew Wilcox
2007-09-27 23:28 ` Matthew Wilcox
2007-09-28 2:21 ` Theodore Tso
2007-09-28 3:22 ` Greg KH
2007-09-28 3:21 ` Greg KH
2007-09-28 3:21 ` Greg KH
2007-09-27 23:41 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927234158.GB10154@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.